Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use preferredMimeType to identity text/plain #104

Merged
merged 1 commit into from
Feb 28, 2023
Merged

refactor: use preferredMimeType to identity text/plain #104

merged 1 commit into from
Feb 28, 2023

Conversation

agoose77
Copy link
Collaborator

I remembered this existed a couple of minutes ago 🤦. This PR doesn't fix any bugs, but this is a better way to handle text rendering.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch executablebooks/jupyterlab-myst/agoose77/refactor-use-preferred-mimetype

rowanc1
rowanc1 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that looks like a simple, and more native addition!

@agoose77 agoose77 added the maintenance Improvements or additions to infrastructure label Feb 28, 2023
@agoose77 agoose77 merged commit cc1ad5a into main Feb 28, 2023
@agoose77 agoose77 deleted the agoose77/refactor-use-preferred-mimetype branch February 28, 2023 00:09
@rowanc1
Copy link
Member

rowanc1 commented Mar 15, 2023

I am fixing this slightly in:

The function has some quirks!

@rowanc1 rowanc1 mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanc1 rowanc1 rowanc1 approved these changes

Assignees
No one assigned
Labels
maintenance Improvements or additions to infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @rowanc1