Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹🧹 Add issue templates #131

Merged
merged 4 commits into from
Mar 24, 2023
Merged

🧹🧹 Add issue templates #131

merged 4 commits into from
Mar 24, 2023

Conversation

kolibril13
Copy link
Contributor

@kolibril13 kolibril13 commented Mar 23, 2023 •
edited
Loading

Follow up to #130.
The templates are quite minimalistic, which I think is good to lower the contribution barrier.
@agoose77 , @rowanc1

EDIT: A preview can be found in a dummy repo here:
https://github.com/kolibril13/okapi2/issues/new/choose

@welcome
Copy link

welcome bot commented Mar 23, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch kolibril13/jupyterlab-myst/issue_pr

@kolibril13 kolibril13 mentioned this pull request Mar 23, 2023
Closed
rowanc1
rowanc1 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and super simple. :)

I will let @agoose77 comment tomorrow and we can get this going. Can always tweak it in the future! 🚀

Thanks @kolibril13!

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@rowanc1 rowanc1 added the maintenance Improvements or additions to infrastructure label Mar 23, 2023
@rowanc1
Copy link
Member

rowanc1 commented Mar 23, 2023

Apparently the linter looks at all markdown files! Can you fix the linting @kolibril13?

kolibril13 and others added 2 commits March 23, 2023 22:15
@kolibril13 @rowanc1
Update .github/ISSUE_TEMPLATE/config.yml
ca6b753 
Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
@kolibril13
run prettier
7d7b2e5
@kolibril13
Copy link
Contributor Author

done! 👍🏼

@agoose77 agoose77 marked this pull request as ready for review March 24, 2023 08:48
@agoose77
Copy link
Collaborator

Thanks @kolibril13! I agree that we want minimal friction here, and these templates look nice and straightfoward!

@agoose77 agoose77 merged commit cb1e33f into jupyter-book:main Mar 24, 2023
@welcome
Copy link

welcome bot commented Mar 24, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@rowanc1
Copy link
Member

rowanc1 commented Mar 24, 2023

Thanks @kolibril13, appreciate the help over in this repo as well!! :)

@kolibril13 kolibril13 mentioned this pull request Mar 27, 2023
Closed
@rowanc1 rowanc1 mentioned this pull request Jun 28, 2023
Closed
@kolibril13 kolibril13 mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanc1 rowanc1 rowanc1 approved these changes

Assignees
No one assigned
Labels
maintenance Improvements or additions to infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolibril13 @rowanc1 @agoose77