Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update with copier #203

Merged
merged 5 commits into from
Feb 5, 2024
Merged

MAINT: update with copier #203

merged 5 commits into from
Feb 5, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Feb 5, 2024

This PR attempts to update our scaffolding using upstream's copier template

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Binder 👈 Launch a Binder on branch executablebooks/jupyterlab-myst/agoose77/chore-upgrade-copier

@agoose77 agoose77 added the maintenance Improvements or additions to infrastructure label Feb 5, 2024
@agoose77 agoose77 merged commit 25ddbcd into main Feb 5, 2024
5 of 7 checks passed
@agoose77 agoose77 deleted the agoose77/chore-upgrade-copier branch February 5, 2024 22:10
@agoose77 agoose77 changed the title wip: update with copier MAINT: update with copier Feb 15, 2024
Comment on lines -42 to +44
if (node.checked == null) {
if (node.checked === null) {
Copy link
Member

@rowanc1 rowanc1 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agoose77 this is actually different logic! Causing the bug in #220.

== null checks for null and undefined.
=== null is a strict check for null.

We could also move to typeof node.checked === 'boolean' which is more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements or additions to infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants