Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sphinx 6 #118

Closed
Tracked by #51
nicoa opened this issue Jan 3, 2023 · 13 comments · Fixed by #106
Closed
Tracked by #51

support sphinx 6 #118

nicoa opened this issue Jan 3, 2023 · 13 comments · Fixed by #106
Labels
enhancement New feature or request

Comments

@nicoa
Copy link

nicoa commented Jan 3, 2023

Context

Some packages are relying on this one to be installed and the pinned dependencies (i.e. the testing pipelines in pydata/pydata-sphinx-theme#1097 ) and it would be nice to have version 6 and up.

Please let me know on your opinion wether simply loosening the restriction is fine or additional tests are required.

Proposal

No response

Tasks and updates

No response

@nicoa nicoa added the enhancement New feature or request label Jan 3, 2023
@welcome
Copy link

welcome bot commented Jan 3, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@zerocewl
Copy link

any news?

@nicoa
Copy link
Author

nicoa commented Jan 13, 2023

Hey @zerocewl , I'm not familiar with this package and got no response on

Please let me know on your opinion wether simply loosening the restriction is fine or additional tests are required.

As there are quite a few votings for this issue, I may put together a quick PR the next days and will see what the maintainers of this repo say.

@zerocewl
Copy link

@nicoa

I'm not sure if there is any active maintainer?!?

A PR would be nice, but would it contain any more then the already (not merged) PR #106?

@chrisjsewell
Copy link
Member

New myst-parser is released, which will let us test on Sphinx 6 here.

working on it 😉 https://github.com/executablebooks/MyST-Parser/commits/master

@nicoa
Copy link
Author

nicoa commented Jan 14, 2023

I guess there are ;-) yes, that PR is actively worked on apparently, you can monitor that one, thanks for pointing out!

@zerocewl
Copy link

bump

@bastimeyer
Copy link

working on it

With the MyST-Parser 0.19.0 release that has added support for Sphinx 6, is there a chance for an update and new release here as well?
https://github.com/executablebooks/MyST-Parser/releases/tag/v0.19.0

Thank you very much!

@dbitouze
Copy link

dbitouze commented Mar 5, 2023

As a MyST-Parser and sphinx-design user, I strongly support this FR!

@bastimeyer
Copy link

So there's PR #106 which simply tries to bump the version range of Sphinx, but it doesn't update myst-parser and the theme dependencies in the optional-dependencies. All of those dependencies do have recent versions though which support Sphinx 6.

Are there any incompatibilities here, or is bumping the dependencies enough?

@Giddius
Copy link

Giddius commented Mar 23, 2023

As far as my docs are concerned, just force installing sphinx 6 after installing sphinx-design and then building, did not break anything.

Windows 10-64
Python 3.11

@bastimeyer
Copy link

Apparently there was an attempt made to move/update to sphinx-design2 in #123 by @chrisjsewell, but the updated project now lives here:
https://github.com/sphinx-extensions2/sphinx-design2

According to its readme, it's "a fork for local development", but it's still published to PyPI:
https://pypi.org/project/sphinx-design2/

However, the readme of the sphinx-extensions2 GH orga suggests that this is indeed the new location for the project:
https://github.com/sphinx-extensions2

Why the fork if repos can just be moved, with a convenient redirection being added by GitHub on the old location? Why the new PyPI package? The sphinx-design2 readme also contains stuff from the old project.

Is sphinx-design2 actually considered stable and available for public use, @chrisjsewell? It does contain the necessary changes for sphinx 6.

@danieljanes
Copy link

@choldgraf, what's your perspective on the comment from @bastimeyer?

It would be great to understand which PyPI package (sphinx_design or sphinx-design2) is more actively maintained to decide which package we should depend on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants