Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid html generated by the tab code #126

Closed
vkbo opened this issue Apr 11, 2023 · 1 comment · Fixed by #195
Closed

Invalid html generated by the tab code #126

vkbo opened this issue Apr 11, 2023 · 1 comment · Fixed by #195

Comments

@vkbo
Copy link

vkbo commented Apr 11, 2023

The code that generates tabs adds an invalid </input> closing tag. The <input> element in HTML doesn't have a closing tag as it's a void element. I expect they are ignored by browsers anyway, but they fail in HTML validation tools.

def depart_tab_input(self, node):
self.body.append("</input>")

@welcome
Copy link

welcome bot commented Apr 11, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant