-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict with pydata-sphinx-theme #180
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
Thanks for this, what do you mean by version switcher? |
I got the same issue and with a little bit of debugging I think I understand the area of the code that's problematic, I'm not quite sure how to properly solve it as I don't have much experience developing for sphinx. I'll put a PR up with what fixes it for me so you can have a look. The gist of it is commenting this line https://github.com/executablebooks/sphinx-tabs/blob/v3.4.1/sphinx_tabs/tabs.py#L333 fixes it. Removing https://github.com/executablebooks/sphinx-tabs/blob/v3.4.1/sphinx_tabs/tabs.py#L361 altogether also fixes it. pydata-sphinx-theme does something a bit unusual with its JS, it's added as inline code without a filename. See: https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/__init__.py#L261-L274. It does appear to be supported by sphinx however. |
Proposed fix: #181 |
Fixed in the latest release, thanks @mathpl 🥳 |
Describe the bug
context
When I do use this package with pydata-sphinx-theme, the version switcher for that project does not work.
expectation
I expected both packages to work without affecting each other.
bug
But instead adding
sphinx_tabs.tabs
to the extensions, without even using a tab, the version switcher for that package no longer works. I filed an issue on that repository, but I figured it might be useful to have this tracked here as well.problem
This is a problem for people wanting use this package with pydata-sphinx-theme
Reproduce the bug
Just follow the steps listed in this issue
List your environment
No response
The text was updated successfully, but these errors were encountered: