Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Always show --help or --version if encountered #34

Closed
ee7 opened this issue Oct 10, 2020 · 0 comments · Fixed by #26
Closed

CLI: Always show --help or --version if encountered #34

ee7 opened this issue Oct 10, 2020 · 0 comments · Fixed by #26
Labels
kind: bug User-facing incorrect behavior

Comments

@ee7
Copy link
Member

ee7 commented Oct 10, 2020

Example

canonical_data_syncer --help --check

Current behaviour

The program ignores the --help and performs --check.

Expected behaviour

  • If the parser encounters -h or --help we should do nothing but show the help.
  • If the parser encounters -v or --version we should do nothing but show the verison.

Try it in your favourite command-line tools.
@ee7 ee7 mentioned this issue Oct 10, 2020
Merged
ee7 added a commit to ee7/exercism-configlet that referenced this issue Oct 12, 2020
@ee7
Fix(cli): Quit immediately on -h, -v
78ad1a2 
This increases the strictness of the parsing.

For example, the command
  `canonical_data_syncer --help --check`

Now prints the help message. Previously, the program silently ignored
`--help` and performed `--check`, which is is unusual behaviour for a
CLI tool.

Fixes: exercism#34
ee7 added a commit to ee7/exercism-configlet that referenced this issue Jan 21, 2021
@ee7
Fix(cli): Quit immediately on -h, -v
79ad65b 
This increases the strictness of the parsing.

For example, the command
  `canonical_data_syncer --help --check`

Now prints the help message. Previously, the program silently ignored
`--help` and performed `--check`, which is is unusual behaviour for a
CLI tool.

Fixes: exercism#34
@ee7 ee7 added the kind: bug User-facing incorrect behavior label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug User-facing incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor(cli): Review of initial version ee7/exercism-configlet
1 participant
@ee7