-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown: explicitly say whether GFM is supported #361
Comments
FYI The additional rendering options that we support are footnotes and allowing unsafe HTML: https://github.com/gjtorikian/commonmarker#render-options |
Thanks. Do we support tables and strikethrough too?
What's the rationale behind using To others, links about footnotes:
|
Yes.
|
No idea. I guess we trust maintainers' code and allow them to do whatever? |
🤷 |
I'd probably lean towards:
|
I believe that the website uses
commonmarker
(see here), which is the wrapper forlibcmark-gfm
. And therefore the website supports rendering a markdown file that uses GitHub Flavored Markdown features.However, the Exercism Markdown spec does not state whether a Markdown file can use GFM features. We should state that explicitly, so that e.g. a track knows whether they can use a tables, task list items, or strikethroughs.
Configlet will soon learn to parse and render Markdown, but this will at least initially only support the CommonMark 0.30 spec (not GFM). If necessary, it should be straightforward for it to support GFM (by wrapping
libcmark-gfm
, rather thanlibcmark
).Somewhat related:
GitHub is thinking about adding a new admonition syntax. See https://talk.commonmark.org/t/4173
But even if the GFM spec is changed, I would suggest that we keep the current admonition syntax:
The text was updated successfully, but these errors were encountered: