Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale-generator exercise #50

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Add scale-generator exercise #50

merged 1 commit into from
Feb 18, 2024

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Feb 10, 2024

No description provided.

@pfertyk pfertyk force-pushed the add-scale-generator-exercise branch 7 times, most recently from 3fbf7ed to 3a7eef5 Compare February 10, 2024 20:50
@pfertyk pfertyk marked this pull request as ready for review February 10, 2024 20:53
@pfertyk
Copy link
Contributor Author

pfertyk commented Feb 10, 2024

@BNAndras another one copied from Python and ready for review ;)

@BNAndras
Copy link
Member

Just a heads up but I remember this exercise being deprecated upstream. Tracks can still implement it of course but if the problem-specifications repo recommends a different exercise to be implemented, we should generally implement that one unless we have a reason to keep the deprecated one. So instead of porting accumulate for example, it’s recommended you implement list-ops.

@BNAndras
Copy link
Member

The issue was that the musical theory behind the problem was confusing to some students. Some tracks have kept the exercise, but some have deprecated it. So it's fine to keep it given that there's no recommended replacement exercise. I'm just highlighting this exercise has some problems, but it might still be a net plus to have the exercise.

@pfertyk pfertyk force-pushed the add-scale-generator-exercise branch from 3a7eef5 to 450d6d6 Compare February 18, 2024 16:45
@pfertyk pfertyk merged commit 4c4a76f into main Feb 18, 2024
2 checks passed
@pfertyk pfertyk deleted the add-scale-generator-exercise branch February 18, 2024 16:47
@pfertyk
Copy link
Contributor Author

pfertyk commented Feb 18, 2024

Acknowledged @BNAndras 👍 For now, I'm adding this exercise, and if we have a good replacement in the future, I will deprecate this one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants