Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse-string: Refactor the lints.rs module #16

Open
ZapAnton opened this issue Jul 7, 2019 · 0 comments
Open

reverse-string: Refactor the lints.rs module #16

ZapAnton opened this issue Jul 7, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@ZapAnton
Copy link
Contributor

ZapAnton commented Jul 7, 2019

The current implementation of the lint functions in the lints.rs module consists of a great number of the deeply nested if let statements with the intermediate logic inside the condition blocks.

Some block could not be avoided, since the dyn keyword inside the pattern matches is not stable yet, but even without it there is a lot of repetitive and hard to maintain code, which potentially can migrate to the other exercise analyzers.

So it would be great to see if the code could be somehow refactored for better readability/maintainability.

@ZapAnton ZapAnton added the help wanted Extra attention is needed label Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant