Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

req.host should be req.hostname #2179

Closed
dougwilson opened this issue Jun 15, 2014 · 1 comment
Closed

req.host should be req.hostname #2179

dougwilson opened this issue Jun 15, 2014 · 1 comment
Labels
5.x enhancement ideas

Comments

@dougwilson
Copy link
Contributor

Currently in express, req.host returns the hostname instead of the host (i.e. it strips the port, if present). This should be renamed to req.hostname in the next major and req.host added that is the actual host and not the hostname.

/cc @dantman
@dougwilson dougwilson mentioned this issue Jul 14, 2014
Merged
39 tasks
@expressjs expressjs locked and limited conversation to collaborators Jul 18, 2014
@hacksparrow
Copy link
Member

Added back req.host to the 5.x docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
5.x enhancement ideas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @hacksparrow