Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish version v0.4.0 #115

Closed
yutannihilation opened this issue Jan 6, 2023 · 9 comments
Closed

Publish version v0.4.0 #115

yutannihilation opened this issue Jan 6, 2023 · 9 comments

Comments

@yutannihilation
Copy link
Contributor

After #113 gets merged, I think it's time to publish it as a new version.

@CGMossa
Copy link
Member

CGMossa commented Feb 24, 2023

I believe what happens now is even releases of ExtendR depends on the github-hosted version of this crate.

@yutannihilation
Copy link
Contributor Author

Sure. Maybe this should be 0.4.0 for consistency with the extendr version?

@multimeric
Copy link
Member

I agree that consistency would be good. Do you need help with anything? This crate isn't really my area.

@eitsupi
Copy link
Contributor

eitsupi commented Feb 25, 2023

A related question, I am wondering if moving libR-sys to a subdirectory of extendr would make it easier to manage.
I saw such a structure in the duckdb-rs repo.
https://github.com/wangfenjin/duckdb-rs

Since Rust 1.64 or later allows the version number etc. to be inherited throughout the workspace, it would reduce the effort of specifying the version in multiple places.

@CGMossa
Copy link
Member

CGMossa commented Feb 25, 2023

@eitsupi o agree with you that this is an option. But this binding project is very useful on its own to people that may want to do things without extendr.
Plus there is so much crap with this package all the time, that @yutannihilation and a few others deal with, that it will be unbearable if they had to also have the burden of the extendr workspace on top.

For now, let's keep them separate still.

@yutannihilation yutannihilation changed the title Publish version 0.3.1 Publish version v0.4.0 Feb 25, 2023
@yutannihilation
Copy link
Contributor Author

yutannihilation commented Feb 25, 2023

I created a pull request for updating the changelog.

https://github.com/extendr/libR-sys/pull/138/files

If this is good, I will

  • Merge the pull request
  • Create tag v0.4.0
  • Publish to Crates.io
  • Create a GitHub release

@yutannihilation
Copy link
Contributor Author

I'll publish the release 12 hours later or so, so please comment if there's any concern.

@multimeric
Copy link
Member

Sounds good, thanks!

@yutannihilation
Copy link
Contributor Author

v0.4.0 is now on crates.io. Thank you for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants