From 568a1af38936035c9aac096569cc3f629a792347 Mon Sep 17 00:00:00 2001
From: mossa <cgmossa@gmail.com>
Date: Thu, 5 Oct 2023 21:31:32 +0200
Subject: [PATCH 1/5] Clippy suggestions

---
 build.rs | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/build.rs b/build.rs
index 6c45778f..167db9ec 100644
--- a/build.rs
+++ b/build.rs
@@ -156,9 +156,7 @@ fn byte_array_to_os_string(bytes: &[u8]) -> OsString {
 
 // Execute an R script and return the captured output
 fn r_command<S: AsRef<OsStr>>(r_binary: S, script: &str) -> io::Result<OsString> {
-    let out = Command::new(r_binary)
-        .args(&["-s", "-e", script])
-        .output()?;
+    let out = Command::new(r_binary).args(["-s", "-e", script]).output()?;
 
     // if there are any errors we print them out, helps with debugging
     if !out.stderr.is_empty() {
@@ -220,7 +218,7 @@ fn get_r_include(r_home: &Path, library: &Path) -> io::Result<PathBuf> {
     }
     .get_r_binary();
 
-    let rout = r_command(&r_binary, r#"cat(normalizePath(R.home('include')))"#)?;
+    let rout = r_command(r_binary, r#"cat(normalizePath(R.home('include')))"#)?;
     if !rout.is_empty() {
         Ok(PathBuf::from(rout))
     } else {
@@ -266,7 +264,7 @@ fn parse_r_version(r_version: String) -> Result<RVersionInfo, EnvVarError> {
             // Bad:
             //   - "4.1.foo" (some part contains any non-digit characters)
             //   - "4.1." (some part is missing)
-            if !s.is_empty() && s.chars().all(|c| c.is_digit(10)) {
+            if !s.is_empty() && s.chars().all(|c| c.is_ascii_digit()) {
                 Some(s)
             } else {
                 None
@@ -330,8 +328,8 @@ fn get_r_version_from_r(r_paths: &InstallationPaths) -> Result<RVersionInfo, Env
     // 4.2.0-devel
     // ```
     let out = r_command(
-        &r_binary,
-        r#"cat(sprintf('%s.%s%s\n', R.version$major, R.version$minor, if(isTRUE(grepl('devel', R.version$status, fixed = TRUE))) '-devel' else ''))"#,
+        r_binary,
+        r"cat(sprintf('%s.%s%s\n', R.version$major, R.version$minor, if(isTRUE(grepl('devel', R.version$status, fixed = TRUE))) '-devel' else ''))",
     )
         .map_err(EnvVarError::RInvocationError)?;
 
@@ -475,7 +473,7 @@ fn generate_bindings(r_paths: &InstallationPaths, version_info: &RVersionInfo) {
     );
 
     // Point to the correct headers
-    bindgen_builder = bindgen_builder.clang_args(&[
+    bindgen_builder = bindgen_builder.clang_args([
         format!("-I{}", r_paths.include.display()),
         format!("--target={target}"),
     ]);
@@ -537,10 +535,12 @@ fn generate_bindings(r_paths: &InstallationPaths, version_info: &RVersionInfo) {
         let out_path = PathBuf::from(alt_target);
         // if folder doesn't exist, try to create it
         if !out_path.exists() {
-            fs::create_dir(&out_path).expect(&format!(
-                "Couldn't create output directory for bindings: {}",
-                out_path.display()
-            ));
+            fs::create_dir(&out_path).unwrap_or_else(|_| {
+                panic!(
+                    "Couldn't create output directory for bindings: {}",
+                    out_path.display()
+                )
+            });
         }
 
         let bindings_file_full = version_info.get_r_bindings_filename(&target_os, &target_arch);
@@ -548,7 +548,7 @@ fn generate_bindings(r_paths: &InstallationPaths, version_info: &RVersionInfo) {
 
         bindings
             .write_to_file(&out_file)
-            .expect(&format!("Couldn't write bindings: {}", out_file.display()));
+            .unwrap_or_else(|_| panic!("Couldn't write bindings: {}", out_file.display()));
     } else {
         println!(
             "Warning: Couldn't write the bindings since `LIBRSYS_BINDINGS_OUTPUT_PATH` is not set."
@@ -605,10 +605,10 @@ impl bindgen::callbacks::ParseCallbacks for TrimCommentsCallbacks {
         let comment = comment.trim();
 
         // replace bare brackets in comments
-        let comment = comment.replace("[", r"\[");
-        let comment = comment.replace("]", r"\]");
+        let comment = comment.replace('[', r"\[");
+        let comment = comment.replace(']', r"\]");
 
-        Some(comment.into())
+        Some(comment)
     }
 }
 

From bae068dd044919a352e666e9bb27fe4bd4bee90e Mon Sep 17 00:00:00 2001
From: mossa <cgmossa@gmail.com>
Date: Thu, 5 Oct 2023 21:39:16 +0200
Subject: [PATCH 2/5] These two now appears in warnings, as there are rust
 equivalent ones.

---
 build.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/build.rs b/build.rs
index 167db9ec..eee5c1b5 100644
--- a/build.rs
+++ b/build.rs
@@ -499,7 +499,9 @@ fn generate_bindings(r_paths: &InstallationPaths, version_info: &RVersionInfo) {
         .blocklist_item("M_2_PI")
         .blocklist_item("M_2_SQRTPI")
         .blocklist_item("M_SQRT2")
-        .blocklist_item("M_SQRT1_2");
+        .blocklist_item("M_SQRT1_2")
+        .blocklist_item("M_2PI")
+        .blocklist_item("M_LOG10_2");
 
     // `VECTOR_PTR` is deprecated, use `DATAPTR` and friends instead
     let bindgen_builder = bindgen_builder.blocklist_item("VECTOR_PTR");

From 5a9fd9850bf8b53ef51100758b3803f9524dff87 Mon Sep 17 00:00:00 2001
From: CGMossa <CGMossa@users.noreply.github.com>
Date: Thu, 5 Oct 2023 20:26:02 +0000
Subject: [PATCH 3/5] Update bindings [skip ci]

---
 bindings/bindings-linux-aarch64-R4.2.rs        | 2 --
 bindings/bindings-linux-aarch64-R4.3.rs        | 2 --
 bindings/bindings-linux-aarch64-R4.4-devel.rs  | 8 +++-----
 bindings/bindings-linux-x86_64-R4.2.rs         | 2 --
 bindings/bindings-linux-x86_64-R4.3.rs         | 2 --
 bindings/bindings-linux-x86_64-R4.4-devel.rs   | 8 +++-----
 bindings/bindings-macos-aarch64-R4.3.rs        | 2 --
 bindings/bindings-macos-x86_64-R4.2.rs         | 2 --
 bindings/bindings-macos-x86_64-R4.3.rs         | 2 --
 bindings/bindings-macos-x86_64-R4.4-devel.rs   | 8 +++-----
 bindings/bindings-windows-x86_64-R4.2.rs       | 2 --
 bindings/bindings-windows-x86_64-R4.3.rs       | 2 --
 bindings/bindings-windows-x86_64-R4.4-devel.rs | 8 +++-----
 13 files changed, 12 insertions(+), 38 deletions(-)

diff --git a/bindings/bindings-linux-aarch64-R4.2.rs b/bindings/bindings-linux-aarch64-R4.2.rs
index 3a40e59e..0c40d277 100644
--- a/bindings/bindings-linux-aarch64-R4.2.rs
+++ b/bindings/bindings-linux-aarch64-R4.2.rs
@@ -146,10 +146,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-aarch64-R4.3.rs b/bindings/bindings-linux-aarch64-R4.3.rs
index dd7de2e7..277c54ed 100644
--- a/bindings/bindings-linux-aarch64-R4.3.rs
+++ b/bindings/bindings-linux-aarch64-R4.3.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-aarch64-R4.4-devel.rs b/bindings/bindings-linux-aarch64-R4.4-devel.rs
index d9a3ece3..64034519 100644
--- a/bindings/bindings-linux-aarch64-R4.4-devel.rs
+++ b/bindings/bindings-linux-aarch64-R4.4-devel.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
@@ -164,9 +162,9 @@ pub const R_MAJOR: &[u8; 2] = b"4\0";
 pub const R_MINOR: &[u8; 4] = b"4.0\0";
 pub const R_STATUS: &[u8; 29] = b"Under development (unstable)\0";
 pub const R_YEAR: &[u8; 5] = b"2023\0";
-pub const R_MONTH: &[u8; 3] = b"09\0";
-pub const R_DAY: &[u8; 3] = b"29\0";
-pub const R_SVN_REVISION: u32 = 85235;
+pub const R_MONTH: &[u8; 3] = b"10\0";
+pub const R_DAY: &[u8; 3] = b"04\0";
+pub const R_SVN_REVISION: u32 = 85267;
 pub const R_GE_definitions: u32 = 13;
 pub const R_GE_deviceClip: u32 = 14;
 pub const R_GE_group: u32 = 15;
diff --git a/bindings/bindings-linux-x86_64-R4.2.rs b/bindings/bindings-linux-x86_64-R4.2.rs
index 9e3925ce..817edb4a 100644
--- a/bindings/bindings-linux-x86_64-R4.2.rs
+++ b/bindings/bindings-linux-x86_64-R4.2.rs
@@ -146,10 +146,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-x86_64-R4.3.rs b/bindings/bindings-linux-x86_64-R4.3.rs
index a6eaadb8..cdbe9f62 100644
--- a/bindings/bindings-linux-x86_64-R4.3.rs
+++ b/bindings/bindings-linux-x86_64-R4.3.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-x86_64-R4.4-devel.rs b/bindings/bindings-linux-x86_64-R4.4-devel.rs
index 33c677e2..a7844500 100644
--- a/bindings/bindings-linux-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-linux-x86_64-R4.4-devel.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
@@ -164,9 +162,9 @@ pub const R_MAJOR: &[u8; 2] = b"4\0";
 pub const R_MINOR: &[u8; 4] = b"4.0\0";
 pub const R_STATUS: &[u8; 29] = b"Under development (unstable)\0";
 pub const R_YEAR: &[u8; 5] = b"2023\0";
-pub const R_MONTH: &[u8; 3] = b"09\0";
-pub const R_DAY: &[u8; 3] = b"30\0";
-pub const R_SVN_REVISION: u32 = 85239;
+pub const R_MONTH: &[u8; 3] = b"10\0";
+pub const R_DAY: &[u8; 3] = b"04\0";
+pub const R_SVN_REVISION: u32 = 85267;
 pub const R_GE_definitions: u32 = 13;
 pub const R_GE_deviceClip: u32 = 14;
 pub const R_GE_group: u32 = 15;
diff --git a/bindings/bindings-macos-aarch64-R4.3.rs b/bindings/bindings-macos-aarch64-R4.3.rs
index f1245aa3..4abe7c46 100644
--- a/bindings/bindings-macos-aarch64-R4.3.rs
+++ b/bindings/bindings-macos-aarch64-R4.3.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.2.rs b/bindings/bindings-macos-x86_64-R4.2.rs
index edb792eb..784bf473 100644
--- a/bindings/bindings-macos-x86_64-R4.2.rs
+++ b/bindings/bindings-macos-x86_64-R4.2.rs
@@ -148,10 +148,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.3.rs b/bindings/bindings-macos-x86_64-R4.3.rs
index 85f224f3..223ec11c 100644
--- a/bindings/bindings-macos-x86_64-R4.3.rs
+++ b/bindings/bindings-macos-x86_64-R4.3.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.4-devel.rs b/bindings/bindings-macos-x86_64-R4.4-devel.rs
index eb5712ca..0e5676cd 100644
--- a/bindings/bindings-macos-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-macos-x86_64-R4.4-devel.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
@@ -166,9 +164,9 @@ pub const R_MAJOR: &[u8; 2] = b"4\0";
 pub const R_MINOR: &[u8; 4] = b"4.0\0";
 pub const R_STATUS: &[u8; 29] = b"Under development (unstable)\0";
 pub const R_YEAR: &[u8; 5] = b"2023\0";
-pub const R_MONTH: &[u8; 3] = b"09\0";
-pub const R_DAY: &[u8; 3] = b"29\0";
-pub const R_SVN_REVISION: u32 = 85235;
+pub const R_MONTH: &[u8; 3] = b"10\0";
+pub const R_DAY: &[u8; 3] = b"05\0";
+pub const R_SVN_REVISION: u32 = 85268;
 pub const R_GE_definitions: u32 = 13;
 pub const R_GE_deviceClip: u32 = 14;
 pub const R_GE_group: u32 = 15;
diff --git a/bindings/bindings-windows-x86_64-R4.2.rs b/bindings/bindings-windows-x86_64-R4.2.rs
index cddfbbd4..6757c3b6 100644
--- a/bindings/bindings-windows-x86_64-R4.2.rs
+++ b/bindings/bindings-windows-x86_64-R4.2.rs
@@ -65,10 +65,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-windows-x86_64-R4.3.rs b/bindings/bindings-windows-x86_64-R4.3.rs
index c8ee0b87..0facca69 100644
--- a/bindings/bindings-windows-x86_64-R4.3.rs
+++ b/bindings/bindings-windows-x86_64-R4.3.rs
@@ -66,10 +66,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-windows-x86_64-R4.4-devel.rs b/bindings/bindings-windows-x86_64-R4.4-devel.rs
index 1b41f8c0..43c6c872 100644
--- a/bindings/bindings-windows-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-windows-x86_64-R4.4-devel.rs
@@ -66,10 +66,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
@@ -83,9 +81,9 @@ pub const R_MAJOR: &[u8; 2] = b"4\0";
 pub const R_MINOR: &[u8; 4] = b"4.0\0";
 pub const R_STATUS: &[u8; 29] = b"Under development (unstable)\0";
 pub const R_YEAR: &[u8; 5] = b"2023\0";
-pub const R_MONTH: &[u8; 3] = b"09\0";
-pub const R_DAY: &[u8; 3] = b"30\0";
-pub const R_SVN_REVISION: u32 = 85239;
+pub const R_MONTH: &[u8; 3] = b"10\0";
+pub const R_DAY: &[u8; 3] = b"04\0";
+pub const R_SVN_REVISION: u32 = 85267;
 pub const R_GE_definitions: u32 = 13;
 pub const R_GE_deviceClip: u32 = 14;
 pub const R_GE_group: u32 = 15;

From a014dd9bab86b46170f35bb99d9ee2292888a2bb Mon Sep 17 00:00:00 2001
From: mossa <cgmossa@gmail.com>
Date: Thu, 5 Oct 2023 21:39:16 +0200
Subject: [PATCH 4/5] These two now appears in warnings, as there are rust
 equivalent ones.

---
 build.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/build.rs b/build.rs
index 167db9ec..eee5c1b5 100644
--- a/build.rs
+++ b/build.rs
@@ -499,7 +499,9 @@ fn generate_bindings(r_paths: &InstallationPaths, version_info: &RVersionInfo) {
         .blocklist_item("M_2_PI")
         .blocklist_item("M_2_SQRTPI")
         .blocklist_item("M_SQRT2")
-        .blocklist_item("M_SQRT1_2");
+        .blocklist_item("M_SQRT1_2")
+        .blocklist_item("M_2PI")
+        .blocklist_item("M_LOG10_2");
 
     // `VECTOR_PTR` is deprecated, use `DATAPTR` and friends instead
     let bindgen_builder = bindgen_builder.blocklist_item("VECTOR_PTR");

From 57cefb1544328f9107e8ffb5c5c6dc95f6f46a7a Mon Sep 17 00:00:00 2001
From: CGMossa <CGMossa@users.noreply.github.com>
Date: Thu, 5 Oct 2023 20:26:02 +0000
Subject: [PATCH 5/5] Update bindings [skip ci]

---
 bindings/bindings-linux-aarch64-R4.2.rs        | 2 --
 bindings/bindings-linux-aarch64-R4.3.rs        | 2 --
 bindings/bindings-linux-aarch64-R4.4-devel.rs  | 2 --
 bindings/bindings-linux-x86_64-R4.2.rs         | 2 --
 bindings/bindings-linux-x86_64-R4.3.rs         | 2 --
 bindings/bindings-linux-x86_64-R4.4-devel.rs   | 2 --
 bindings/bindings-macos-aarch64-R4.3.rs        | 2 --
 bindings/bindings-macos-x86_64-R4.2.rs         | 2 --
 bindings/bindings-macos-x86_64-R4.3.rs         | 2 --
 bindings/bindings-macos-x86_64-R4.4-devel.rs   | 2 --
 bindings/bindings-windows-x86_64-R4.2.rs       | 2 --
 bindings/bindings-windows-x86_64-R4.3.rs       | 2 --
 bindings/bindings-windows-x86_64-R4.4-devel.rs | 2 --
 13 files changed, 26 deletions(-)

diff --git a/bindings/bindings-linux-aarch64-R4.2.rs b/bindings/bindings-linux-aarch64-R4.2.rs
index 3a40e59e..0c40d277 100644
--- a/bindings/bindings-linux-aarch64-R4.2.rs
+++ b/bindings/bindings-linux-aarch64-R4.2.rs
@@ -146,10 +146,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-aarch64-R4.3.rs b/bindings/bindings-linux-aarch64-R4.3.rs
index dd7de2e7..277c54ed 100644
--- a/bindings/bindings-linux-aarch64-R4.3.rs
+++ b/bindings/bindings-linux-aarch64-R4.3.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-aarch64-R4.4-devel.rs b/bindings/bindings-linux-aarch64-R4.4-devel.rs
index 0305d666..64034519 100644
--- a/bindings/bindings-linux-aarch64-R4.4-devel.rs
+++ b/bindings/bindings-linux-aarch64-R4.4-devel.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-x86_64-R4.2.rs b/bindings/bindings-linux-x86_64-R4.2.rs
index 9e3925ce..817edb4a 100644
--- a/bindings/bindings-linux-x86_64-R4.2.rs
+++ b/bindings/bindings-linux-x86_64-R4.2.rs
@@ -146,10 +146,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-x86_64-R4.3.rs b/bindings/bindings-linux-x86_64-R4.3.rs
index a6eaadb8..cdbe9f62 100644
--- a/bindings/bindings-linux-x86_64-R4.3.rs
+++ b/bindings/bindings-linux-x86_64-R4.3.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-linux-x86_64-R4.4-devel.rs b/bindings/bindings-linux-x86_64-R4.4-devel.rs
index 0aa46117..a7844500 100644
--- a/bindings/bindings-linux-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-linux-x86_64-R4.4-devel.rs
@@ -147,10 +147,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-aarch64-R4.3.rs b/bindings/bindings-macos-aarch64-R4.3.rs
index f1245aa3..4abe7c46 100644
--- a/bindings/bindings-macos-aarch64-R4.3.rs
+++ b/bindings/bindings-macos-aarch64-R4.3.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.2.rs b/bindings/bindings-macos-x86_64-R4.2.rs
index edb792eb..784bf473 100644
--- a/bindings/bindings-macos-x86_64-R4.2.rs
+++ b/bindings/bindings-macos-x86_64-R4.2.rs
@@ -148,10 +148,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.3.rs b/bindings/bindings-macos-x86_64-R4.3.rs
index 85f224f3..223ec11c 100644
--- a/bindings/bindings-macos-x86_64-R4.3.rs
+++ b/bindings/bindings-macos-x86_64-R4.3.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-macos-x86_64-R4.4-devel.rs b/bindings/bindings-macos-x86_64-R4.4-devel.rs
index e1771660..0e5676cd 100644
--- a/bindings/bindings-macos-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-macos-x86_64-R4.4-devel.rs
@@ -149,10 +149,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-windows-x86_64-R4.2.rs b/bindings/bindings-windows-x86_64-R4.2.rs
index cddfbbd4..6757c3b6 100644
--- a/bindings/bindings-windows-x86_64-R4.2.rs
+++ b/bindings/bindings-windows-x86_64-R4.2.rs
@@ -65,10 +65,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-windows-x86_64-R4.3.rs b/bindings/bindings-windows-x86_64-R4.3.rs
index c8ee0b87..0facca69 100644
--- a/bindings/bindings-windows-x86_64-R4.3.rs
+++ b/bindings/bindings-windows-x86_64-R4.3.rs
@@ -66,10 +66,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;
diff --git a/bindings/bindings-windows-x86_64-R4.4-devel.rs b/bindings/bindings-windows-x86_64-R4.4-devel.rs
index 0d953359..43c6c872 100644
--- a/bindings/bindings-windows-x86_64-R4.4-devel.rs
+++ b/bindings/bindings-windows-x86_64-R4.4-devel.rs
@@ -66,10 +66,8 @@ pub const HAVE_EXPM1: u32 = 1;
 pub const HAVE_HYPOT: u32 = 1;
 pub const HAVE_LOG1P: u32 = 1;
 pub const HAVE_WORKING_LOG1P: u32 = 1;
-pub const M_2PI: f64 = 6.283185307179586;
 pub const M_SQRT_3: f64 = 1.7320508075688772;
 pub const M_SQRT_32: f64 = 5.656854249492381;
-pub const M_LOG10_2: f64 = 0.3010299956639812;
 pub const M_SQRT_PI: f64 = 1.772453850905516;
 pub const M_1_SQRT_2PI: f64 = 0.3989422804014327;
 pub const M_SQRT_2dPI: f64 = 0.7978845608028654;