Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Parameterize the type of the Secret manifest #134

Closed
eshamay opened this issue Jul 23, 2019 · 1 comment
Closed

Parameterize the type of the Secret manifest #134

eshamay opened this issue Jul 23, 2019 · 1 comment

Comments

@eshamay
Copy link

eshamay commented Jul 23, 2019

The fstab/cifs FlexVolume plugin (among others) requires secrets to be created with type: fstab/cifs. However, the upserted secrets are all created with type: Opaque. This results in errors such as:

MountVolume.SetUp failed for volume "foo-volume-mount" : Couldn't get secret foo-project/volume-mount-secret. err: Cannot get secret of type fstab/cifs

It would be helpful to parameterize the type used in the final manifest, and allow that to flow through to the poller as needed.
@eshamay
Copy link
Author

eshamay commented Jul 23, 2019

Looks like this was already tracked by #130 (review)

@eshamay eshamay closed this as completed Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eshamay