Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

added the option to enforce namespace annotations #448

Merged
merged 3 commits into from
Jul 26, 2020

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Jul 22, 2020

Namespace annotations are amazing, but there is no way to make them mandatory. Added an env var that when set, makes those annotations mandatory.

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice addition! Some minor nit comments, otherwise looks good

lib/poller.js Outdated Show resolved Hide resolved
config/environment.js Outdated Show resolved Hide resolved
omerlh and others added 2 commits July 26, 2020 08:13
Co-authored-by: Markus Maga <markus@maga.se>
Co-authored-by: Markus Maga <markus@maga.se>
@omerlh
Copy link
Contributor Author

omerlh commented Jul 26, 2020

Thanks!

@Flydiverny Flydiverny merged commit 1517333 into external-secrets:master Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants