This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Better naming for Prometheus metrics #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabouzaid
force-pushed
the
rename-prometheus-metrics
branch
4 times, most recently
from
9c26896
to
beff894
Compare
aabouzaid
force-pushed
the
rename-prometheus-metrics
branch
from
beff894
to
54bc1ca
Compare
Flydiverny
approved these changes
Nov 14, 2020
Closed
MPV
reviewed
Dec 22, 2020
| labelNames: ['name', 'namespace', 'backend', 'status'], | ||
| registers: [registry] | ||
| }) | ||
| this._lastSyncCallState = new Prometheus.Gauge({ | ||
| name: 'kubernetes_external_secrets_last_sync_call_state', | ||
| help: 'State of last sync call of external secert. Value -1 if the last sync was a failure, 1 otherwise', |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR refactors the metrics' names according to Prometheus metric names best practices.
No breaking changes at the moment since I added new metrics and added deprecation notes on the old ones.
Related to: #489