Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quality of life improvements #32

Closed
nilslice opened this issue Jul 23, 2024 · 2 comments · Fixed by #38
Closed

quality of life improvements #32

nilslice opened this issue Jul 23, 2024 · 2 comments · Fixed by #38

Comments

@nilslice
Copy link
Member

nilslice commented Jul 23, 2024

  1. errors
    error formatting could be improved vs. setting a []const u8.. more like https://github.com/ziglang/zig/blob/master/lib/std/fmt.zig#L83

e.g.

try plugin.allocError("some error {s}", .{ err });

(this probably applies generally, wherever we take []const u8 for things to signal info back to the host.. e.g. logging perhaps)

  1. use new std HTTP types
    such as the HTTP methods and other items where possible

thank you to @ethanholz for the inspiration and user report on Twitch! (https://www.twitch.tv/ninja_tron)

  1. make LogLevel public
    then its more flexible to write wrapper logging functions
@nilslice
Copy link
Member Author

nilslice commented Nov 4, 2024

Sorry this took so long to get around to! But there's a PR open at #38

@ethanholz
Copy link

These looks cool! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants