Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on electron #14

Closed
goodhyun opened this issue Jan 12, 2018 · 1 comment
Closed

Error on electron #14

goodhyun opened this issue Jan 12, 2018 · 1 comment

Comments

@goodhyun
Copy link

const fetch = require('node-fetch');
is causing the following error on an electron/webkit environment

 WARNING in ./~/encoding/lib/iconv-loader.js
Critical dependencies:
9:12-34 the request of a dependency is an expression
 @ ./~/encoding/lib/iconv-loader.js 9:12-34

It'd be okay. We can use the browser's built-in fetch.

What would be a nicer mitigation on this problem than just to comment them out ??

@ndaidong
Copy link
Collaborator

ndaidong commented Jan 14, 2018

Please check this issue #41 if it gives you some ideas?

@ndaidong ndaidong closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants