Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multi-line commit messages #1171

Closed
florealcab opened this issue Mar 10, 2022 · 9 comments
Closed

Create multi-line commit messages #1171

florealcab opened this issue Mar 10, 2022 · 9 comments
Labels

Comments

@florealcab
Copy link

Is your feature request related to a problem? Please describe.
Commit with gitui allow only one commit line, without commit description (like is allowed with commit -m command)

Describe the solution you'd like
Allow to add a description to the commit: with a new description field, or simply with a multi-line commit

@kosayoda
Copy link
Contributor

If you press the Open editor key (default is ^e) while the commit window is open, you can edit the commit message using a text editor (similar to what git commit does).

@extrawurst
Copy link
Owner

See also #509

@florealcab
Copy link
Author

If you press the Open editor key (default is ^e) while the commit window is open, you can edit the commit message using a text editor (similar to what git commit does).

Yes it did the trick thank you :)

See also #509

Better to do that! Hope will be merged soon :D

@Zeioth
Copy link

Zeioth commented Apr 4, 2022

I'm here for this same reason. A message in the commit window saying the user to press ctrl+e for multi-line commits, while we make something better, wouldn't hurt.

@extrawurst
Copy link
Owner

marking as good first issue, since its just about finishing the draft PR #509

@IgnisDa
Copy link

IgnisDa commented Mar 1, 2023

Any updates on this? @extrawurst

@crispinb
Copy link

I'll have a look to see if I can finish off #1309.

@extrawurst - are you open to assessing https://github.com/rhysd/tui-textarea/ for this purpose? I ask not yet knowing the gitui codebase (hence implications) nor your attitude to deps. I've tried a couple of the examples and it seems nice on the face of it not to have to roll-your-own scrolling & cursor etc. It might also have other uses within gitui perhaps?

If you're open to it I'll explore that route first briefly as a test of fit and report back. If not I'll disinter the above PR and see what I might do with it.

@crispinb
Copy link

Ah. I see now there's an issue already suggesting use of tui-textarea, which should give us multiline input for free. So never mind for now. I'll keep an eye on that issue in case help's needed at any stage. It would be a good one to get over the line.

@extrawurst extrawurst modified the milestones: v0.23, v0.24 Jun 19, 2023
@extrawurst extrawurst modified the milestones: v0.24, v0.25 Aug 21, 2023
@extrawurst
Copy link
Owner

closing favor of #2045

@extrawurst extrawurst removed this from the v0.25 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants