-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official Homebrew formula #137
Conversation
@vladimyr this is fantastic! thank you❤️ |
Yeah, I'm the one to blame 😁
Well there is this nice little gem that can save you from manually updating it: https://github.com/mislav/bump-homebrew-formula-action I can do a PR if you like, but be warned that I'm not really experienced with tweaking Github workflows 🙃 |
@vladimyr could you checkout the current step: https://github.com/extrawurst/gitui/blob/master/.github/workflows/cd.yml#L74 if you are familiar with the brew command line you could tell me if this should also work if we rewire it to go against the official repo, right? |
Hm, it should you just need to omit personal tap from invocation 🤔 |
With one change tho, I've used automatically generated tarball inside Homebrew formula (https://github.com/extrawurst/gitui/archive/v0.7.0.tar.gz) instead of mac specific one. |
@vladimyr thanks again, it worked perfectly and is released in |
@vladimyr oh no I was too fast there, look the auto update does not touch the test part of the formulae: Homebrew/homebrew-core#57537 😭 |
I would say that isn't just a plain update anymore 🤷 |
@vladimyr I am lost here. you came up with the original formulae, is the test section a requirement? I can't seem to get it to work: Homebrew/homebrew-core#57537 |
Yes, the test section is a requirement and one of the acceptance criteria for the formula to be distributed through homebrew-core tap. However, the test shouldn't get updated on regular releases. The only reason for touching it would be if there are breaking changes introduced with a new release. Give me some time and I'll try to address issues you are seeing there... |
GitUI got successfully submitted to the official Homebrew repo. 🎉
https://formulae.brew.sh/formula/gitui#default