Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official Homebrew formula #137

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

vladimyr
Copy link
Contributor

GitUI got successfully submitted to the official Homebrew repo. 🎉
https://formulae.brew.sh/formula/gitui#default

@extrawurst extrawurst merged commit 35926ef into extrawurst:master Jun 16, 2020
@extrawurst
Copy link
Owner

@vladimyr this is fantastic! thank you❤️
Did you do this? Currently the CD pipeline automatically updates my personal tap on release - how do we handle the official repo?

@vladimyr
Copy link
Contributor Author

Did you do this?

Yeah, I'm the one to blame 😁

Currently the CD pipeline automatically updates my personal tap on release - how do we handle the official repo?

Well there is this nice little gem that can save you from manually updating it: https://github.com/mislav/bump-homebrew-formula-action I can do a PR if you like, but be warned that I'm not really experienced with tweaking Github workflows 🙃

@vladimyr vladimyr deleted the homebrew branch June 16, 2020 19:38
@extrawurst
Copy link
Owner

@vladimyr could you checkout the current step: https://github.com/extrawurst/gitui/blob/master/.github/workflows/cd.yml#L74

if you are familiar with the brew command line you could tell me if this should also work if we rewire it to go against the official repo, right?

@vladimyr
Copy link
Contributor Author

Hm, it should you just need to omit personal tap from invocation 🤔
In the meantime, I already did #138 🙃

@vladimyr
Copy link
Contributor Author

With one change tho, I've used automatically generated tarball inside Homebrew formula (https://github.com/extrawurst/gitui/archive/v0.7.0.tar.gz) instead of mac specific one.

@extrawurst
Copy link
Owner

@vladimyr thanks again, it worked perfectly and is released in 0.8 now: https://github.com/extrawurst/gitui/releases/tag/v0.8.0

@extrawurst
Copy link
Owner

@vladimyr oh no I was too fast there, look the auto update does not touch the test part of the formulae: Homebrew/homebrew-core#57537 😭

@vladimyr
Copy link
Contributor Author

vladimyr commented Jul 6, 2020

@vladimyr oh no I was too fast there, look the auto update does not touch the test part of the formulae: Homebrew/homebrew-core#57537 😭

I would say that isn't just a plain update anymore 🤷

@extrawurst
Copy link
Owner

@vladimyr I am lost here. you came up with the original formulae, is the test section a requirement? I can't seem to get it to work: Homebrew/homebrew-core#57537

@vladimyr
Copy link
Contributor Author

vladimyr commented Jul 6, 2020

Yes, the test section is a requirement and one of the acceptance criteria for the formula to be distributed through homebrew-core tap. However, the test shouldn't get updated on regular releases. The only reason for touching it would be if there are breaking changes introduced with a new release. Give me some time and I'll try to address issues you are seeing there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants