Tags not showing in log

[albertogg]

Hi, this is a very cool TUI, thank you. I was testing it out and found myself needing to look at which commits are tagged within the Log. It seems that this is not happening despite seeing that the feature was implemented in #47. I haven't look at the code.

Expected behavior
Seeing the tag next to the commit message.

Screenshots

Here are a couple of screenshots. One is with GitUp showing the tag in the commit, and the second one is the Log on GitUI.

Context (please complete the following information):

• OS/Distro + Version: macOS 10.14.6
• GitUI Version: 0.8.1
• Rust version: 1.42

[extrawurst]

@albertogg thanks for reporting this. I cannot reproduce the problem for tags pointing to commits in the current branch. Is the repo you experience the issue open source to reproduce?

[albertogg]

Thanks for the quick response... yes, it is. It's this one https://github.com/qmk/qmk_firmware.

[extrawurst]

So turns out to be an issue in the library I am using to interact with the git repo: https://libgit2.org - I am working on a small repro for them to look into.

[albertogg]

ha, Interesting. I see that you already put the work rust-lang/git2-rs#594. Thanks! let's see how this goes.

[extrawurst]

got it. aside from the linked ticket my code still had a shortcoming in dealing with tags that are directly pointing to the commit and tags that take a detour, weird stuff happening in git sometimes... anyway looks better huh:

[albertogg]

Nice, I can imagine. very fast turn around. thanks!

[extrawurst]

@albertogg btw. this is what confused me in the base c++ lib: libgit2/libgit2#5586

[albertogg]

I see, If you don't annotate the tag they will be "lightweight", that behavior seems odd, I would have never thought of that. But I don't completely understand... is the rust library using the c++ library underneath?

[extrawurst]

@albertogg exactly, libgit2 is the base library powering gitlab and gitkraken and git2-rs is the rust safety wrapper that I am using