-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrolling to long commit messages #208
Add scrolling to long commit messages #208
Conversation
cruessler
commented
Jul 20, 2020
•
edited
Loading
edited
- Manually wrap commit messages
- Add commands for navigation: focus commit message
- Add scrolling to component
- Add tests
@cruessler the windows build was broken due to #210 - once you rebase onto current master CI should be fine again |
c7e6cde
to
64c85f8
Compare
@extrawurst I updated the PR. Scrolling is not yet included, because I first wanted to ask whether the PR goes into the right direction. If so, adding the remaining parts should hopefully not be too difficult. |
@cruessler from a first glance this looks like the way to go 👍 some nitpicks: let's not keep highlighting the top entry in the tree while the commit message is focused. I am also not sure about highlighting a line in the commit message🤔 |
64c85f8
to
ea58250
Compare
@extrawurst I have incorporated your feedback, so the PR should be near feature-complete. The only thing missing are a few tests. |
@cruessler really cool, a few tests would be good 👍 |
ea58250
to
49f71a0
Compare
@extrawurst I just added a few tests. Let me know if you want more! |
unfortunately it looks not right to me, something is off here: please checkout the amount of up arrows needed until it actually starts scrolling up and how it takes many down-arrow before it starts scrolling down again. also the clip shows how the entire text is bold instead of only the first line (like it was before). Can you look into that? You can reproduce it with 1c3295a in the |
- Manually wrap commit message using `textwrap` Closes extrawurst#181
49f71a0
to
b8976a0
Compare
@extrawurst Thanks for the feedback! My first solution was needlessly complicated because it tracked My terminal was not configured to show bold text, so I did not notice the other issue before. I fixed that, too. |
@cruessler really cool! thanks for having pulled through with this! great job!❤️ |