Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git pull (fetch+simple merge) #319

Closed
extrawurst opened this issue Oct 9, 2020 · 3 comments · Fixed by #556
Closed

git pull (fetch+simple merge) #319

extrawurst opened this issue Oct 9, 2020 · 3 comments · Fixed by #556
Assignees
Milestone

Comments

@extrawurst
Copy link
Owner

extrawurst commented Oct 9, 2020

git pull is short for git-fetch + git-merge/git-rebase.
I added asyncgit::fetch_origin already so now all that's left is to merge/rebase afterwards.

this is to be more specific than #90

@extrawurst extrawurst added this to the v0.11 milestone Oct 9, 2020
@extrawurst extrawurst self-assigned this Oct 28, 2020
@remique
Copy link
Contributor

remique commented Oct 28, 2020

I might be wrong, but wouldn't it be better to first implement an interface for merging and solving conflicts? And then reuse that interface when fast-forward pull is not possible?

@extrawurst
Copy link
Owner Author

yeah I am at that point, I am reducing the scope of this to conflict free merging and otherwise will discard the merge with an error message. the whole merging/conflict story is post-0.11

@extrawurst extrawurst changed the title git pull git pull (fetch+simple merge) Oct 28, 2020
@extrawurst extrawurst removed this from the v0.11 milestone Dec 19, 2020
@extrawurst
Copy link
Owner Author

extrawurst commented Feb 28, 2021

so good news. the fast forward merge support works. I'd like to cleanup somethings first and then tackle three-way merging in a separate ticket. for now we have a secret key f that performs a fetch and tries to ff-merge. its a start.

todo:

  • show progress of ongoing fetch
  • prominent place to show repo state if not in clean state (in prep for merging)
  • understandable error if ff-merge does not work
  • fetch progress notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants