Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't discard commit message entered without confirmation #530

Closed
focusaurus opened this issue Feb 22, 2021 · 2 comments · Fixed by #532
Closed

Don't discard commit message entered without confirmation #530

focusaurus opened this issue Feb 22, 2021 · 2 comments · Fixed by #532
Labels
enhancement New feature or request

Comments

@focusaurus
Copy link

Is your feature request related to a problem? Please describe.

So for vim users where typing ESC to exit insert mode is deep deep muscle memory, I find myself hitting c to commit, typing a message then by reflex typing ESC and having gitui discard the message I just crafted.

Anyone else shooting themselves with this footgun too?

Describe the solution you'd like

If the commit message is still empty, OK to close with a single ESC. But maybe if there's content entered, prompt to confirm before discarding?

Describe alternatives you've considered

Well something other than ESC would solve it too but that might make the overall keybinding style inconsistent.

A clear and concise description of any alternative solutions or features you've considered.

@extrawurst
Copy link
Owner

fair point, actually this was the behaviour at some point. I agree we should go back to that 👍

@extrawurst extrawurst added the enhancement New feature or request label Feb 22, 2021
@focusaurus
Copy link
Author

Yay! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants