Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate lag when tabbing over file-tree first time #756

Closed
extrawurst opened this issue Jun 1, 2021 · 1 comment · Fixed by #760
Closed

investigate lag when tabbing over file-tree first time #756

extrawurst opened this issue Jun 1, 2021 · 1 comment · Fixed by #760
Milestone
v0.16.1

Comments

@extrawurst
Copy link
Owner

only happens in big repos
@extrawurst
Copy link
Owner Author

turns out most of the time was spend in FileTreeItems::create_items because I was using BTreeMap where ordering does not matter and a HashMap performs 3x better.

old:
Screenshot 2021-06-01 at 23 53 05

new:
Screenshot 2021-06-01 at 23 55 22

@extrawurst extrawurst mentioned this issue Jun 1, 2021
Merged
@extrawurst extrawurst added this to the v0.16.1 milestone Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.1
Development

Successfully merging a pull request may close this issue.

improve filetree::new performance extrawurst/gitui
1 participant
@extrawurst