Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app error handling using anyhow #77

Closed
extrawurst opened this issue May 20, 2020 · 2 comments
Closed

app error handling using anyhow #77

extrawurst opened this issue May 20, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@extrawurst
Copy link
Owner

now that we have nice error coverage in asyncgit we could take the next step and add error support to the main application using anyhow based on the great summary on error handling in rust:

my idea would be to show an error popup similar to this one where ever possible: #74 (comment)

if we come across unrecoverable errors we might need to look into a second path aswell which will close the application.

@extrawurst extrawurst added the enhancement New feature or request label May 20, 2020
@extrawurst
Copy link
Owner Author

extrawurst commented May 21, 2020

one problem is going to be external libraries (dependencies) that do not go full no-unwrap too. Currently we have one of those issue with tui-rs: #72

@MCord
Copy link
Contributor

MCord commented May 21, 2020

I am working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants