-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contrast for selected branch in branch popup for light themes #922
Comments
Did you try to change that color using a local custom gitui theme? |
Hi! I don't think it can be changed through the gitui theme, I believe it's just the default terminal foreground color being used here. I just posted the PR: #923 |
@cottser thanks! can you post a comparison screenshot with your change? |
@extrawurst definitely, I forgot to post those. Do you want those in here, in the PR, or both? |
here is fine |
Looks like this may actually improve contrast in some dark themes as well. |
Thanks @extrawurst! |
Describe the bug
The contrast for the branch name for the selected branch could be improved for light themes (see screenshots below).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected this to have better contrast
Screenshots
Context (please complete the following information):
Additional context
The contrast is even worse (invisible, black-on-black) with my own terminal/gitui theme.
The text was updated successfully, but these errors were encountered: