Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast for selected branch in branch popup for light themes #922

Closed
star-szr opened this issue Sep 29, 2021 · 8 comments · Fixed by #923
Closed

Improve contrast for selected branch in branch popup for light themes #922

star-szr opened this issue Sep 29, 2021 · 8 comments · Fixed by #923

Comments

@star-szr
Copy link
Contributor

Describe the bug
The contrast for the branch name for the selected branch could be improved for light themes (see screenshots below).

To Reproduce
Steps to reproduce the behavior:

  1. Open the branch modal
  2. Look at the selected branch

Expected behavior
I expected this to have better contrast

Screenshots

before-light
before-dark

Context (please complete the following information):

  • OS/Distro + Version: Pop!_OS 21.04 (Ubuntu-like)
  • GitUI Version 0.17.1
  • Rust version: 1.55.0

Additional context
The contrast is even worse (invisible, black-on-black) with my own terminal/gitui theme.

@extrawurst
Copy link
Owner

Did you try to change that color using a local custom gitui theme?

@star-szr
Copy link
Contributor Author

Hi! I don't think it can be changed through the gitui theme, I believe it's just the default terminal foreground color being used here.

I just posted the PR: #923

@extrawurst
Copy link
Owner

@cottser thanks! can you post a comparison screenshot with your change?

@star-szr
Copy link
Contributor Author

@extrawurst definitely, I forgot to post those. Do you want those in here, in the PR, or both?

@extrawurst
Copy link
Owner

@extrawurst definitely, I forgot to post those. Do you want those in here, in the PR, or both?

here is fine

@star-szr
Copy link
Contributor Author

Dark theme, before and after:
before-dark
after-dark

Light theme, before and after:
before-light

after-light

@star-szr
Copy link
Contributor Author

Looks like this may actually improve contrast in some dark themes as well.

@star-szr
Copy link
Contributor Author

Solarized dark, before/after:
before-solarized-dark
after-solarized-dark

Thanks @extrawurst!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants