Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some options to work on files/directories (create, delete, modify, rename, etc.) #989

Closed
chlopes opened this issue Nov 16, 2021 · 7 comments · Fixed by #1023
Closed
Labels
enhancement New feature or request
Milestone

Comments

@chlopes
Copy link

chlopes commented Nov 16, 2021

Hi!

I've just found the project so maybe I'm missing something but I didn't find a way to invoke the editor ("Edit [e]" option) from the Files [3] tab to start modifying files. Also, I've not found the options to create, delete and rename files/directories through it.

Maybe these options are out of the scope of the project, I don't know, but I think it'd be nice to have them for small and quick changes, thus avoiding context switches.

Thanks for the outstanding job! Just keep it up!

@extrawurst extrawurst added the enhancement New feature or request label Nov 16, 2021
@extrawurst
Copy link
Owner

I didn't find a way to invoke the editor ("Edit [e]" option) from the Files [3] tab

thats not implemented yet, but that makes sense actually!

I've not found the options to create, delete and rename files/directories through it.

I am not sure I want to go down that path, I also do not see parallels in the git GUI apps that inspired gitui (looking at Fork)

@chlopes
Copy link
Author

chlopes commented Nov 16, 2021

thats not implemented yet, but that makes sense actually!

Good to know :)

I am not sure I want to go down that path, I also do not see parallels in the git GUI apps that inspired gitui (looking at Fork)

I understand your concerns but I do hope you consider adding it because it complements the feature above, fulfilling the need of managing project files directly through the tool.

@extrawurst
Copy link
Owner

I understand your concerns but I do hope you consider adding it because it complements the feature above, fulfilling the need of managing project files directly through the tool.

still this should be a separate issue so we can prioritise it differently. the edit [e] part is a low hanging fruit, the other part not as much. can you split these two things?

@chlopes
Copy link
Author

chlopes commented Nov 16, 2021

can you split these two things?

Absolutely!

Shall we keep this issue for the edit [e] part and just open a new one for the other part or do you prefer to close this one and open another two separately?

@extrawurst
Copy link
Owner

Let’s keep this one for the edit cmd

@extrawurst extrawurst added this to the v0.19 milestone Nov 30, 2021
@extrawurst
Copy link
Owner

implemented with one oddity: since the file tree reflects a revision of the tree changing a file that we see there will not be reflected afterwards in the tree view. therefore I switch to the status tab when editing a file

@mark2185
Copy link
Contributor

since the file tree reflects a revision of the tree changing a file that we see there will not be reflected afterwards in the tree view

Why is that? I found it odd changing a file and seeing the view of the file in the Files tab to remain unchanged. And yet, editing said file shows the actual state of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants