Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to show no-undef ? #11

Closed
leviwheatcroft opened this issue Dec 30, 2017 · 5 comments
Closed

possible to show no-undef ? #11

leviwheatcroft opened this issue Dec 30, 2017 · 5 comments

Comments

@leviwheatcroft
Copy link

Not really sure if this is possible or if this is the right module, but it would be super helpful if eslint could show undefined variables used in the pug template.

@ezhlobo
Copy link
Owner

ezhlobo commented Jan 1, 2018

@leviwheatcroft thank you for mentioning this. Yes, this is right place and it's on my roadmap. I can't promise you a deadline, but I'll keep you updated ;).

@ezhlobo ezhlobo mentioned this issue Feb 2, 2018
3 tasks
@ezhlobo
Copy link
Owner

ezhlobo commented Feb 2, 2018

@leviwheatcroft hey, this notification is just for keeping you updated with progress.

I've started and implemented 'proof of concept'. Remaining part is to do refactoring and extend README. It also requires some time because I would like to test that rule in my current project, so probably it will be merged in 1 week.

You can test it as well right now by adding explicit dependency in package.json:

"eslint-plugin-react-pug": "https://github.com/ezhlobo/eslint-plugin-react-pug.git#rule/no-undef"

BTW, now it looks not very good because it marks the whole template as an error, so it might be tricky to find not defined variable in big template.

screen shot 2018-02-02 at 21 02 07

@leviwheatcroft
Copy link
Author

nice! I'll take a look

@ezhlobo
Copy link
Owner

ezhlobo commented Feb 26, 2018

@leviwheatcroft hey, I've just published 0.2 version which supports this rule. If you have not tried it yet, then now just increase version number in your package.json ;).

Please, re-open this issue if that update does not resolve your concern.

@ezhlobo ezhlobo closed this as completed Feb 26, 2018
@leviwheatcroft
Copy link
Author

awesome. thanks. love your work mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants