Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabio 1.3.6 UI displays host and path as 'undefined' in the routes page #217

Closed
bluen opened this issue Jan 18, 2017 · 3 comments
Closed
Labels
Milestone

Comments

@bluen
Copy link

bluen commented Jan 18, 2017

Seems to affect the ui/api only - the actual routing seems to work...

The following shows the routing entries of 3 docker containers "nginxdemos/hello:latest" registered
in consul with tags urlprefix-hello.service.consul:9999/, green and latest for fabio-1.3.5 and fabio-1.3.6 (running in docker containers) visible in the browser.

fabio 1.3.5 output of http://fabio:9998/api/routes

[
    {
        "service": "hello",
        "host": "hello.service.consul:9999",
        "path": "/",
        "dst": "http://10.7.0.23:48224/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "cmd": "route add hello hello.service.consul:9999/ http://10.7.0.23:48224/ weight 0.33 tags \"green,urlprefix-hello.service.consul:9999/,latest\"",
        "rate1": 0,
        "pct99": 0
    },
    {
        "service": "hello",
        "host": "hello.service.consul:9999",
        "path": "/",
        "dst": "http://10.7.0.22:29747/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "cmd": "route add hello hello.service.consul:9999/ http://10.7.0.22:29747/ weight 0.33 tags \"green,urlprefix-hello.service.consul:9999/,latest\"",
        "rate1": 0,
        "pct99": 0
    },
    {
        "service": "hello",
        "host": "hello.service.consul:9999",
        "path": "/",
        "dst": "http://10.7.0.21:23652/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "cmd": "route add hello hello.service.consul:9999/ http://10.7.0.21:23652/ weight 0.33 tags \"green,urlprefix-hello.service.consul:9999/,latest\"",
        "rate1": 0,
        "pct99": 0
    }
]

fabio 1.3.6 of the exact same:

[
    {
        "cmd": "route add",
        "service": "hello",
        "src": "hello.service.consul:9999/",
        "dst": "http://10.7.0.23:48224/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "rate1": 0,
        "pct99": 0
    },
    {
        "cmd": "route add",
        "service": "hello",
        "src": "hello.service.consul:9999/",
        "dst": "http://10.7.0.22:29747/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "rate1": 0,
        "pct99": 0
    },
    {
        "cmd": "route add",
        "service": "hello",
        "src": "hello.service.consul:9999/",
        "dst": "http://10.7.0.21:23652/",
        "weight": 0.3333333333333333,
        "tags": [
            "green",
            "urlprefix-hello.service.consul:9999/",
            "latest"
        ],
        "rate1": 0,
        "pct99": 0
    }
]

I think the ui (javascript) tries to read the values for "host" and "path" from the JSON fields with the same name - but in 1.3.6 those fields do not exist (but the values can be parsed from the "src" field")

@bluen
Copy link
Author

bluen commented Jan 18, 2017

Screen shots:
fabio-1.3.5 - fabio-1 3 5
fabio-1.3.6 - fabio-1 3 6

@magiconair
Copy link
Contributor

Yes, I made a boo-boo. master has the fix already. Sorry about that.

@magiconair magiconair changed the title fabio 1.3.6 UI displays host and path as 'undefined' in the routes page, fabio 1.3.6 UI displays host and path as 'undefined' in the routes page Jan 19, 2017
@magiconair magiconair added the bug label Jan 19, 2017
@magiconair magiconair added this to the 1.3.7 milestone Jan 19, 2017
@magiconair
Copy link
Contributor

Released 1.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants