Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open statements lead to react error #95

Open
whitetigle opened this issue Jul 13, 2018 · 6 comments
Open

open statements lead to react error #95

whitetigle opened this issue Jul 13, 2018 · 6 comments

Comments

@whitetigle
Copy link

whitetigle commented Jul 13, 2018

Hi,
just stumbled on this problem:

this does not work

  open Fable.Recharts
  open Fable.Recharts.Props
  module SVG = Fable.Helpers.React.Props
  open Fable.Helpers.React

and leads to this error:

warning.js:33 Warning: React does not recognize the dataKey prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase datakey instead. If you accidentally passed it from a parent component, remove it from the DOM element.

meanwhile this works

  open Fable.Recharts
  open Fable.Recharts.Props
  module SVG = Fable.Helpers.React.Props
  // open Fable.Helpers.React

maybe something with modules loading?

@whitetigle
Copy link
Author

BTW: Fable 1.3.17

@alfonsogarciacaro
Copy link
Member

That's weird, Fable doesn't do anything for opening statements. Maybe the last opening is shadowing something from Recharts, does this work?

  open Fable.Helpers.React
  open Fable.Recharts
  open Fable.Recharts.Props
  module SVG = Fable.Helpers.React.Props

@MangelMaxime
Copy link
Member

Seems like DataKey is defined only in recharts bindings. Perhaps you used it on an HTML element ?

@swrhim
Copy link

swrhim commented Dec 1, 2020

I ran into the same problem where ordering of the open statements was preventing my chart for recharts from being rendered with the same error message. Should this issue be referenced from this repo?

@alfonsogarciacaro
Copy link
Member

Yes, that may be a good idea. Maybe opening an issue in fable-rcharts with a descriptive title that references this one. What Fable version are you using btw?

@swrhim
Copy link

swrhim commented Dec 1, 2020

Version 3. I'm using the latest SAFE template before .net 5 was announced. (not sure if that has something different)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants