Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withReactHydrate #19

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Add withReactHydrate #19

merged 1 commit into from
Mar 5, 2018

Conversation

zaaack
Copy link
Contributor

@zaaack zaaack commented Mar 2, 2018

Since fable-react is now supported server-side rendering, I think we can add React's new ssr API (.hydrate) for elmish-react.

Currently I only add a version without raf optimization in this PR, not sure I should add a raf optimized version like withReactHydrayeAnimationFrameOptimized (maybe it's too long?)

@et1975
Copy link
Member

et1975 commented Mar 2, 2018

Looks like you'll need to add the new paket (bootstrapper) to the PR to get the CI to build - with 5.141.0 or later release.

@zaaack
Copy link
Contributor Author

zaaack commented Mar 3, 2018

@et1975 ping...

@et1975 et1975 merged commit ce395af into elmish:master Mar 5, 2018
@et1975
Copy link
Member

et1975 commented Mar 5, 2018

Thank you!

@et1975
Copy link
Member

et1975 commented Mar 5, 2018

Released as 2.0.0-beta-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants