diff --git a/doc/MIGRATION-v6.md b/doc/MIGRATION-v6.md index 051d8f19eff..447a5ee0cd3 100644 --- a/doc/MIGRATION-v6.md +++ b/doc/MIGRATION-v6.md @@ -13,6 +13,8 @@ - [Adapt Changes](#adapt-changes) - [Deprecations](#deprecations) - [Object sorting](#object-sorting) +- [Boolean Changes](#boolean-changes) +- [evict Changes](#evict-changes) ## Namespace Changes @@ -164,4 +166,12 @@ Client.isAdaptable and Client.adapt will check first if the existing instance is ## Object Sorting -KubernetesList and Template will no longer automatically sort their objects by default. You may use the HasMetadataComparator to sort the items as needed. \ No newline at end of file +KubernetesList and Template will no longer automatically sort their objects by default. You may use the HasMetadataComparator to sort the items as needed. + +## Boolean Changes + +The usage of Boolean in the api was removed where it was not a nullable value. Please expect a boolean primitive from methods such as delete, copy, or as an argument in Loggable.getLog + +## Evict Changes + +Evictable.evict will throw an exception rather than returning false if the pod is not found. This ensures that false strictly means that the evict failed. \ No newline at end of file diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/ContainerResource.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/ContainerResource.java index 36c05e57ca4..ee0f9e4af23 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/ContainerResource.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/ContainerResource.java @@ -16,8 +16,8 @@ package io.fabric8.kubernetes.client.dsl; -public interface ContainerResource +public interface ContainerResource extends TtyExecInputOutputErrorable, - FileSelector>, + FileSelector>, TimestampBytesLimitTerminateTimeTailPrettyLoggable { } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Copiable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Copiable.java index 1988c466e3d..7a308bea324 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Copiable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Copiable.java @@ -17,7 +17,7 @@ import java.nio.file.Path; -public interface Copiable { - - T copy(Path destination); +public interface Copiable { + + boolean copy(Path destination); } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/CopyOrReadable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/CopyOrReadable.java index 0312ccf7249..7ecca34387d 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/CopyOrReadable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/CopyOrReadable.java @@ -15,6 +15,6 @@ */ package io.fabric8.kubernetes.client.dsl; -public interface CopyOrReadable extends Copiable, Readable, Uploadable { +public interface CopyOrReadable extends Copiable, Readable, Uploadable { } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java index 733fa30b6b1..0d0b0166d2a 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java @@ -22,6 +22,6 @@ public interface Deletable { * @return value indicating object was deleted or not * @throws io.fabric8.kubernetes.client.KubernetesClientException if an error occurs. */ - Boolean delete(); + boolean delete(); } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Evictable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Evictable.java index 859bc5a97ff..33ec54ee6a5 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Evictable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Evictable.java @@ -17,20 +17,20 @@ import io.fabric8.kubernetes.api.model.policy.v1.Eviction; -public interface Evictable { +public interface Evictable { /** * Evicts resource, respecting {@link io.fabric8.kubernetes.api.model.policy.v1beta1.PodDisruptionBudget} * @return value indicating object was evicted or not - * @throws io.fabric8.kubernetes.client.KubernetesClientException if an error occurs. + * @throws io.fabric8.kubernetes.client.KubernetesClientException if an error occurs, including if the Pod is not found. */ - B evict(); + boolean evict(); /** * Evicts a pod from its node subject to certain policies and safety constraints. * * @param eviction Eviction object * @return value indicating object was evicted or not - * @throws io.fabric8.kubernetes.client.KubernetesClientException if an error occurs. + * @throws io.fabric8.kubernetes.client.KubernetesClientException if an error occurs, including if the Pod is not found. */ - B evict(Eviction eviction); + boolean evict(Eviction eviction); } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Loggable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Loggable.java index af310bbb051..6d147f754b0 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Loggable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Loggable.java @@ -39,7 +39,7 @@ public interface Loggable { * @param isPretty whether we need logs with pretty output or not * @return logs as string */ - String getLog(Boolean isPretty); + String getLog(boolean isPretty); /** * Get a Reader for reading logs diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/MultiDeleteable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/MultiDeleteable.java index 5c920eff2c3..34fd72ed86b 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/MultiDeleteable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/MultiDeleteable.java @@ -20,7 +20,7 @@ public interface MultiDeleteable { - Boolean delete(T... items); + boolean delete(T... items); - Boolean delete(List items); + boolean delete(List items); } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/PodResource.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/PodResource.java index c11ca191ec5..42b01e374bd 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/PodResource.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/PodResource.java @@ -15,6 +15,9 @@ */ package io.fabric8.kubernetes.client.dsl; +import io.fabric8.kubernetes.client.LocalPortForward; +import io.fabric8.kubernetes.client.PortForward; + import java.io.InputStream; import java.io.OutputStream; import java.io.PipedInputStream; @@ -22,13 +25,10 @@ import java.nio.channels.ReadableByteChannel; import java.nio.channels.WritableByteChannel; -import io.fabric8.kubernetes.client.LocalPortForward; -import io.fabric8.kubernetes.client.PortForward; - public interface PodResource extends Resource, Loggable, - Containerable>, - ContainerResource, + Containerable>, + ContainerResource, PortForwardable, - Evictable{ + Evictable{ } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Uploadable.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Uploadable.java index eecda26edbc..1c57a8dc3c1 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Uploadable.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Uploadable.java @@ -18,7 +18,7 @@ import java.io.InputStream; import java.nio.file.Path; -public interface Uploadable { +public interface Uploadable { /** * Upload file located at specified {@link Path} to Pod @@ -26,7 +26,7 @@ public interface Uploadable { * @param path path of the file which needs to be uploaded * @return boolean value regarding upload was successful or not. */ - T upload(Path path); + boolean upload(Path path); /** * Upload file extracted from provided InputStream to Pod @@ -34,5 +34,5 @@ public interface Uploadable { * @param inputStream {@link InputStream} which will be uploaded * @return boolean value regarding upload was successful or not. */ - T upload(InputStream inputStream); + boolean upload(InputStream inputStream); } diff --git a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/extension/ResourceAdapter.java b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/extension/ResourceAdapter.java index 6abc22e2439..9dfb8d03e85 100644 --- a/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/extension/ResourceAdapter.java +++ b/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/extension/ResourceAdapter.java @@ -62,7 +62,7 @@ public ResourceAdapter(Resource resource) { } @Override - public Boolean delete() { + public boolean delete() { return resource.delete(); } diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/BaseOperation.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/BaseOperation.java index bb63f58953d..506bd206907 100755 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/BaseOperation.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/BaseOperation.java @@ -439,7 +439,7 @@ private ListOptions defaultListOptions(ListOptions options, Boolean watch) { } @Override - public Boolean delete() { + public boolean delete() { if (item != null || (name != null && !name.isEmpty())) { try { deleteThis(); @@ -465,12 +465,12 @@ public Boolean delete() { @SafeVarargs @Override - public final Boolean delete(T... items) { + public final boolean delete(T... items) { return delete(Arrays.asList(items)); } @Override - public Boolean delete(List items) { + public boolean delete(List items) { boolean deleted = true; if (items != null) { for (T toDelete : items) { diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java index dcea524781a..9b817c77079 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java @@ -228,9 +228,9 @@ public Waitable, HasMetadata> createOrReplaceAnd() { } @Override - public Boolean delete() { + public boolean delete() { for (Resource impl : getResources()) { - if (Boolean.FALSE.equals(impl.delete())) { + if (!impl.delete()) { return false; } } diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/DeploymentOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/DeploymentOperationsImpl.java index fcde82a2479..4ba958fd105 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/DeploymentOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/DeploymentOperationsImpl.java @@ -267,7 +267,7 @@ private void waitUntilDeploymentIsScaled(final int count) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { StringBuilder stringBuilder = new StringBuilder(); List> rcList = doGetLog(); for (RollableScalableResource rcOperation : rcList) { diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/ReplicaSetOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/ReplicaSetOperationsImpl.java index bf8b0e6ad0f..6ba886f50e0 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/ReplicaSetOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/ReplicaSetOperationsImpl.java @@ -153,7 +153,7 @@ public Status rollback(DeploymentRollback deploymentRollback) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return PodOperationUtil.getLog(doGetLog(isPretty), isPretty); } diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/StatefulSetOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/StatefulSetOperationsImpl.java index 21a6afea895..a772eff708b 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/StatefulSetOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/StatefulSetOperationsImpl.java @@ -138,7 +138,7 @@ public Status rollback(DeploymentRollback deploymentRollback) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return PodOperationUtil.getLog(doGetLog(isPretty), isPretty); } diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/batch/v1/JobOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/batch/v1/JobOperationsImpl.java index 87c221dc040..db41262a2bd 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/batch/v1/JobOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/batch/v1/JobOperationsImpl.java @@ -116,7 +116,7 @@ public String getLog() { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { StringBuilder stringBuilder = new StringBuilder(); List> podOperationList = doGetLog(false); for (PodResource podOperation : podOperationList) { diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java index 18898ab7b85..f2a8ec7d0ff 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java @@ -25,7 +25,6 @@ import java.io.PipedInputStream; import java.io.PipedOutputStream; import java.io.Reader; -import java.net.HttpURLConnection; import java.net.InetAddress; import java.net.MalformedURLException; import java.net.URL; @@ -86,7 +85,7 @@ import io.fabric8.kubernetes.client.utils.internal.PodOperationUtil; import io.fabric8.kubernetes.client.lib.FilenameUtils; -public class PodOperationsImpl extends HasMetadataOperation> implements PodResource,CopyOrReadable { +public class PodOperationsImpl extends HasMetadataOperation> implements PodResource,CopyOrReadable { public static final int HTTP_TOO_MANY_REQUESTS = 429; private static final Integer DEFAULT_POD_LOG_WAIT_TIMEOUT = 5; @@ -201,7 +200,7 @@ public Reader getLogReader() { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return new PodOperationsImpl(getContext().withPrettyOutput(isPretty), context).getLog(); } @@ -266,7 +265,7 @@ public LocalPortForward portForward(int port, InetAddress localInetAddress, int } @Override - public Boolean evict() { + public boolean evict() { Eviction eviction = new EvictionBuilder() .withNewMetadata() .withName(getName()) @@ -278,11 +277,11 @@ public Boolean evict() { } @Override - public Boolean evict(io.fabric8.kubernetes.api.model.policy.v1.Eviction eviction) { + public boolean evict(io.fabric8.kubernetes.api.model.policy.v1.Eviction eviction) { return handleEvict(eviction); } - private Boolean handleEvict(HasMetadata eviction) { + private boolean handleEvict(HasMetadata eviction) { try { if (Utils.isNullOrEmpty(eviction.getMetadata().getNamespace())) { throw new KubernetesClientException("Namespace not specified, but operation requires it."); @@ -296,7 +295,7 @@ private Boolean handleEvict(HasMetadata eviction) { handleResponse(requestBuilder, null, Collections.emptyMap()); return true; } catch (KubernetesClientException e) { - if (e.getCode() != HttpURLConnection.HTTP_NOT_FOUND && e.getCode() != HTTP_TOO_MANY_REQUESTS) { + if (e.getCode() != HTTP_TOO_MANY_REQUESTS) { throw e; } return false; @@ -309,7 +308,7 @@ private Boolean handleEvict(HasMetadata eviction) { } @Override - public ContainerResource inContainer(String containerId) { + public ContainerResource inContainer(String containerId) { return new PodOperationsImpl(getContext().withContainerId(containerId), context); } @@ -364,17 +363,17 @@ URL getURLWithCommandParams(String[] commands) throws MalformedURLException { } @Override - public CopyOrReadable file(String file) { + public CopyOrReadable file(String file) { return new PodOperationsImpl(getContext().withFile(file), context); } @Override - public CopyOrReadable dir(String dir) { + public CopyOrReadable dir(String dir) { return new PodOperationsImpl(getContext().withDir(dir), context); } @Override - public Boolean copy(Path destination) { + public boolean copy(Path destination) { try { if (Utils.isNotNullOrEmpty(getContext().getFile())) { copyFile(getContext().getFile(), destination.toFile()); @@ -390,7 +389,7 @@ public Boolean copy(Path destination) { } @Override - public Boolean upload(InputStream inputStream) { + public boolean upload(InputStream inputStream) { return wrapRunWithOptionalDependency(() -> { try { return PodUpload.uploadFileData(httpClient, getContext(), this, inputStream); @@ -402,7 +401,7 @@ public Boolean upload(InputStream inputStream) { } @Override - public Boolean upload(Path path) { + public boolean upload(Path path) { return wrapRunWithOptionalDependency(() -> { try { return PodUpload.upload(httpClient, getContext(), this, path); diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ReplicationControllerOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ReplicationControllerOperationsImpl.java index 0ab8462ce20..d87fca83bac 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ReplicationControllerOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ReplicationControllerOperationsImpl.java @@ -133,7 +133,7 @@ public Status rollback(DeploymentRollback deploymentRollback) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return PodOperationUtil.getLog(doGetLog(isPretty), isPretty); } diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/DeploymentOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/DeploymentOperationsImpl.java index 90d1f40b3ae..939ea58a9e5 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/DeploymentOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/DeploymentOperationsImpl.java @@ -264,7 +264,7 @@ private void waitUntilDeploymentIsScaled(final int count) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { StringBuilder stringBuilder = new StringBuilder(); List> rcList = doGetLog(); for (RollableScalableResource rcOperation : rcList) { diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/ReplicaSetOperationsImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/ReplicaSetOperationsImpl.java index f200268c690..a15a25f3890 100644 --- a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/ReplicaSetOperationsImpl.java +++ b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/ReplicaSetOperationsImpl.java @@ -155,7 +155,7 @@ public Status rollback(DeploymentRollback deploymentRollback) { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { StringBuilder stringBuilder = new StringBuilder(); List> podOperationList = doGetLog(isPretty); for (PodResource podOperation : podOperationList) { diff --git a/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/PodTest.java b/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/PodTest.java index 88854c1ef54..2ce6d6fb459 100644 --- a/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/PodTest.java +++ b/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/PodTest.java @@ -234,8 +234,8 @@ void testEvict() { assertTrue(deleted); // not found - deleted = client.pods().withName("pod2").evict(); - assertFalse(deleted); + PodResource podResource = client.pods().withName("pod2"); + assertThrows(KubernetesClientException.class, () -> podResource.evict()); deleted = client.pods().inNamespace("ns1").withName("pod2").evict(); assertTrue(deleted); diff --git a/openshift-client/src/main/java/io/fabric8/openshift/client/DefaultOpenShiftClient.java b/openshift-client/src/main/java/io/fabric8/openshift/client/DefaultOpenShiftClient.java index 9096836274b..026432b1f72 100644 --- a/openshift-client/src/main/java/io/fabric8/openshift/client/DefaultOpenShiftClient.java +++ b/openshift-client/src/main/java/io/fabric8/openshift/client/DefaultOpenShiftClient.java @@ -360,7 +360,7 @@ public NameableCreateOrDeleteable imageSignatures() { return new NameableCreateOrDeleteable() { @Override - public Boolean delete() { + public boolean delete() { return operation.delete(); } diff --git a/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/apps/DeploymentConfigOperationsImpl.java b/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/apps/DeploymentConfigOperationsImpl.java index ebed65146a7..2aa9d13cd3f 100644 --- a/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/apps/DeploymentConfigOperationsImpl.java +++ b/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/apps/DeploymentConfigOperationsImpl.java @@ -199,7 +199,7 @@ public String getLog() { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return doGetLog(isPretty, String.class); } diff --git a/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildOperationsImpl.java b/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildOperationsImpl.java index b5f1fb079b7..0b456064916 100644 --- a/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildOperationsImpl.java +++ b/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildOperationsImpl.java @@ -136,7 +136,7 @@ public String getLog() { } @Override - public String getLog(Boolean isPretty) { + public String getLog(boolean isPretty) { return new BuildOperationsImpl(getContext().withPrettyOutput(isPretty), context).getLog(); }