-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PodSpec should be considered Buildable in all extensions #2976
Comments
From discussion:
Approaches for the PodSpec/RevisionSpec class with our current setup could be:
|
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
Given the the referenced issue has been worked around I removed my self from the assignee list. |
@iocanel is this related to the changes in sundrio/sundrio#374 and sundrio/sundrio#350 or does there still need to be an explicit declaration that PodSpec is Buildable? |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
The issue is that PodSpec which is part of the core model, is also used in extensions (e.g. knative).
By not considering it Buidlable, visitors are broken causing lots of issues in downstream projects.
A manifestation of the issue: quarkusio/quarkus#16376
So, PodSpec needs to be included.
Ideally, we should be more to be more generic and somehow include all core types.
The text was updated successfully, but these errors were encountered: