Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current "create-react-app" main branch not working (react-scripts) #11692

Open
marioil opened this issue Nov 29, 2021 · 6 comments
Open

Current "create-react-app" main branch not working (react-scripts) #11692

marioil opened this issue Nov 29, 2021 · 6 comments

Comments

@marioil
Copy link

marioil commented Nov 29, 2021

I followed the recommended way of extending "react-scripts" build procedure:
https://create-react-app.dev/docs/alternatives-to-ejecting/

It turns out that there is something wrong in the main branch, because I can't build my project. I receive an error about wrong babel plugin import. No code changes are made by side.

Steps to reproduce:

  1. Fork create-react-app repository
  2. Go to: packages/react-scripts
  3. publish this as an NPM package
  4. Install this package as your "react-scripts" module in your CRA project
  5. Try to build the project
@nelson360
Copy link

creating react app youll have to install npm and visual studio
run
@@@
npx create-react-app my-app
cd my-app
npm start
@@
after successful visual studio download

@marioil
Copy link
Author

marioil commented Dec 6, 2021

Not sure what exactly you want to say here. Do you want to be more descriptive?

@nelson360
Copy link

https://www.youtube.com/watch?v=-ERWlp828kY follow this instructions

@marioil
Copy link
Author

marioil commented Dec 8, 2021

https://www.youtube.com/watch?v=-ERWlp828kY follow this instructions

I don't think you understood the actual problem. I need to extend the react-scripts build procedure. In order to modify/add additional steps in the React build you can either eject the entire project or fork the react-scripts repository and do the modifications there. This is what I'm doing for two years already and everything is working great. From time to time I rebase my custom "react-scripts" repository with the upstream in order to be up to date. And now, two years later after rebase, my "build" is not working. After some investigation I found out that the official "main" branch has issues which are nothing to do with me. This is why I report that there is a problem and it's actually easy to reproduce.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022
@sabarnix
Copy link

sabarnix commented May 9, 2022

I am trying to do the same thing and facing the exact issue.

The postinstall script in package.json does not exist which breaks after npm install or lerna bootstrap. Also, in lerna.json the npm client set is yarn but the yarn.lock file is missing.

@stale stale bot removed the stale label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants