-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate .gitignore at the same time README.md and package.json are created (before npm install) #6452
Labels
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
My proposal still stands. |
I don't think this bot should fire for issues which haven't had maintainer activity. |
This was referenced Mar 16, 2020
This was referenced Nov 17, 2020
This was referenced Mar 28, 2021
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to propose that
.gitignore
gets created at the same timeREADME.md
andpackage.json
do. Right now from experimentation it seems like the two do get created first, thennpm install
is run and then a bunch of other files including.gitignore
gets dropped into the directory.There's probably a reason for that, maybe the
.gitignore
gets copied from the scripts package, I don't know, but still, maybe an interim.gitignore
could be created which ignoresnode_modules
?The reason I ask for this is because when I run
create-react-app .
(create in the current directory) in the VS Code Terminal, VS Code tries to calculate changes at npm-install-time and often runs into the too may changes state, which is a wasted effort ultimately, because at the end of the CRA creation, the Git ignore file gets dropped and the resulting set of changes is correct.Providing the Git ignore file upfront (before
npm install
) or providing an interim one to be replaced by the filed one would solve this issue and make the experience a bit nicer.The text was updated successfully, but these errors were encountered: