Internal URLs ending with a slash are no longer accepted by the URL validator

[ilg-ul]

According to RFC 3986, URLs ending with a slash are legal, and up to Docusaurus 3.1.0 they were accepted.

With the canary 0.0.0-5814, the validator complains about such URLs.

To test this create a new site with:

npx create-docusaurus@0.0.0-5814 website classic --typescript

Edit the blog/2021-08-26-welcome/index.md file and add the following two lines at the end:

[pass](/blog/first-blog-post)
[fail](/blog/first-blog-post/)

The site build fails with:

Error: Unable to build website for locale en.
    at tryToBuildLocale (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/commands/build.js:55:19)
    at async mapAsyncSequential (/Users/ilg/tmp/website/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
    at async Command.build (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/commands/build.js:82:21) {
  [cause]: Error: Docusaurus found broken links!
  
  Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
  Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.
  
  It looks like some of the broken links we found appear in many pages of your site.
  Maybe those broken links appear on all pages through your site layout?
  We recommend that you check your theme configuration for such links (particularly, theme navbar and footer).
  Frequent broken links are linking to:
  - /blog/first-blog-post/
  
  Exhaustive list of all broken links found:
  - Broken link on source page path = /blog:
     -> linking to /blog/first-blog-post/
  - Broken link on source page path = /blog/tags/docusaurus:
     -> linking to /blog/first-blog-post/
  - Broken link on source page path = /blog/tags/facebook:
     -> linking to /blog/first-blog-post/
  - Broken link on source page path = /blog/tags/hello:
     -> linking to /blog/first-blog-post/
  - Broken link on source page path = /blog/welcome:
     -> linking to /blog/first-blog-post/
  
      at throwError (/Users/ilg/tmp/website/node_modules/@docusaurus/logger/lib/index.js:79:11)
      at reportBrokenLinks (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/server/brokenLinks.js:222:47)
      at handleBrokenLinks (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/server/brokenLinks.js:254:5)
      at buildLocale (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/commands/build.js:192:47)
      at async tryToBuildLocale (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/commands/build.js:46:20)
      at async mapAsyncSequential (/Users/ilg/tmp/website/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
      at async Command.build (/Users/ilg/tmp/website/node_modules/@docusaurus/core/lib/commands/build.js:82:21)
}

[INFO] Docusaurus version: 0.0.0-5814
Node version: v18.18.2

I don't know if this is an intended behaviour, or a bug that came with the recent commits.

[slorber]

Thanks, this is a bug introduced in canary 5813 as part of my optimization of the broken link checker (#9778)

Looks similar to what @andrewgbell reported here, but this time I can reproduce: #9758 (comment)

I'll fix it now

[ilg-ul]

I was about to update my site to remove the trailing slashes, but in this case I'll wait for your commit.

Thank you.

[slorber]

👍

I confirm after this fix the broken link checker will not report the url with a trailing slash anymore on your repro:

#9791

[ilg-ul]

I confirm that with the latest commit I can again generate my site.

Thank you for your quick fix.