Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic default project #1172

Closed
Labels
good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. status: claimed Issue has been claimed by a contributor who plans to work on it.

Comments

@alexkrolick
Copy link
Contributor

alexkrolick commented Dec 30, 2018

🚀 Feature

The default examples contain lots of inline paths to things like /img/docusaurus.svg which have to be manually replaced. It would be easier to get up and running if the places where a default image like the project logo are likely to be used referenced either a config variable or a more generic path like /img/logo-large.png.

There are also a few Facebook branding things like the FB Open Source logo which have to be deleted 90% of the time.

Have you read the Contributing Guidelines on issues?

yes

Motivation

To make it less tedious to customize the homepage, footer, etc.

@endiliey endiliey added the good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. label Mar 20, 2019
@tanaypratap
Copy link

I think this can help docusaurus to be used by more and more people. I would like to take this up. Please assign if you(@endiliey ) feel a PR to this issue can be merged.

@endiliey
Copy link
Contributor

endiliey commented Apr 9, 2019

Sure @tanaypratap, feel free to take this up. We are definitely accepting for this kind of PR.

Few reasons:

  1. Its not breaking anything
  2. All the motivation above.

@tanaypratap
Copy link

That's cool. Expect the PR anytime next week. You can assign it to me or set assigned tag on it. I had to go through so many good first issue to find an issue which no one is working on.

@endiliey endiliey added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Apr 9, 2019
@endiliey
Copy link
Contributor

Still working on it @tanaypratap ? By the way let's move to #1196

It seems to be related. Generic (no branded) default project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment