Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeblock Copy button styling broken in "classic" template #2523

Closed
Noah-Silvera opened this issue Apr 3, 2020 · 2 comments · Fixed by #2526
Closed

Codeblock Copy button styling broken in "classic" template #2523

Noah-Silvera opened this issue Apr 3, 2020 · 2 comments · Fixed by #2526
Assignees
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Noah-Silvera
Copy link
Contributor

Noah-Silvera commented Apr 3, 2020

🐛 Bug Report

The copy button styling for the codeblock in the "classic" template is broken. The "copy" text is dark against a dark background

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

1.Initialize a new docusaurus project using the create script and "classic" template
* https://v2.docusaurus.io/docs/installation#scaffold-project-website
2. Add a code block
3. Hover over the code block

Expected behavior

The copy button is activated, with the "copy" text clearly visible

copy-button-working

Actual Behavior

The copy button text is dark against a dark background, so you cannot see the purpose of the button.

copy-button-bug

Your Environment

Docusaurus 2.0.0-alpha.50
Chrome Version 80.0.3987.149 (Official Build) (64-bit)

Reproducible Demo

https://github.com/Noah-Silvera/docusaurus-code-block-bug

@Noah-Silvera Noah-Silvera added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 3, 2020
@dalexhd
Copy link

dalexhd commented Apr 3, 2020

I also had the same issue. Currently we will need to wait until next release. #2502 (comment)_

@lex111
Copy link
Contributor

lex111 commented Apr 3, 2020

Sorry about this, as a workaround (temporary) solution, you can define your own Prism theme for dark mode as done on v2.

@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 3, 2020
@yangshun yangshun self-assigned this Apr 4, 2020
@yangshun yangshun removed the status: needs triage This issue has not been triaged by maintainers label Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants