Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2: blog "draft" frontmatter #3305

Closed
slorber opened this issue Aug 18, 2020 · 6 comments · Fixed by #3346
Closed

V2: blog "draft" frontmatter #3305

slorber opened this issue Aug 18, 2020 · 6 comments · Fixed by #3346
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. mlh Major League Hacking Fellowship

Comments

@slorber
Copy link
Collaborator

slorber commented Aug 18, 2020 •
edited
Loading

🚀 Feature

v1 has draft: true frontmatter for blog posts so that the page of the blog post exists but does not appear

#1396

Let's not forget to port it to v2.

It's an easy feature so if someone wants to give it a try :)

Note: we should ensure that the created page for the blog post does not appear in the sitemaps, otherwise that draft blog post could be indexed by Google. That part might be more complicated.
@slorber slorber added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. mlh Major League Hacking Fellowship and removed status: needs triage This issue has not been triaged by maintainers labels Aug 18, 2020
@slorber slorber changed the title feat(v2): Blog "unlisted" frontmatter V2: blog "unlisted" frontmatter Aug 18, 2020
@slorber slorber changed the title V2: blog "unlisted" frontmatter V2: blog "draft" frontmatter Aug 18, 2020
@imskr
Copy link
Contributor

imskr commented Aug 22, 2020

@slorber I would like to fix this! Please assign!

@slorber
Copy link
Collaborator Author

slorber commented Aug 25, 2020

Thanks @imskr you can work on this

@imskr
Copy link
Contributor

imskr commented Aug 25, 2020

@slorber Thanks since I am new here. Just to confirm, I have to make changes here right?

@slorber
Copy link
Collaborator Author

slorber commented Aug 27, 2020

Hey @imskr yes it's the place.

Seems like it's actually already implemented: https://github.com/facebook/docusaurus/blob/master/packages/docusaurus-plugin-content-blog/src/blogUtils.ts#L126

Maybe only the docs is missing, can you double-check and add the doc please?

Also curious, can you check the sitemaps plugin behavior regarding this draft frontmatter? (we can track/fix this in a separate issue, not sure what's the solution yet)

@imskr
Copy link
Contributor

imskr commented Aug 27, 2020

@slorber Yeah sure let me check!

@imskr imskr mentioned this issue Aug 27, 2020
Merged
@imskr
Copy link
Contributor

imskr commented Aug 27, 2020

@slorber Please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. mlh Major League Hacking Fellowship
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(v2): add draft doc imskr/docusaurus
2 participants
@slorber @imskr