Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page scroll on search (Website) #4088

Closed
kalinpatel opened this issue Jan 22, 2021 · 4 comments · Fixed by #4188
Closed

Page scroll on search (Website) #4088

kalinpatel opened this issue Jan 22, 2021 · 4 comments · Fixed by #4188
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@kalinpatel
Copy link

📚 Documentation

When on the documentation website, pressing search, then clicking escape or clicking away from the search scrolls the page to the bottom. This is unexpected, as I would assume to be in the same place that I left off at.

Have you read the Contributing Guidelines on issues?

Yes
@kalinpatel kalinpatel added documentation The issue is related to the documentation of Docusaurus status: needs triage This issue has not been triaged by maintainers labels Jan 22, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 27, 2021

Hi,

I can't reproduce this behavior on Docusaurus 2 website, so I'm closing.

Feel free to provide much more details on how to reproduce exactly, and I'll re-open.

@slorber slorber closed this as completed Jan 27, 2021
@kalinpatel
Copy link
Author

This seems to be on Safari only. Here is a quick recording of what occurred for me. (the first time was via clicking on the search field, the second time was by pressing CMD+K)

Screen.Recording.2021-01-27.at.2.16.05.PM.mov

@slorber slorber reopened this Jan 28, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 28, 2021

Thanks, I can reproduce that on safari 😓

@slorber
Copy link
Collaborator

slorber commented Jan 28, 2021

@Shipow @francoischalifour afaik the scroll lock/restore is managed by DocSearch. Do you know about this scroll problem on Safari? Does it affect other DocSearch v3 deployments or it's just a Docusaurus problem?

@lex111 lex111 mentioned this issue Feb 7, 2021
Merged
@Josh-Cena Josh-Cena added bug An error in the Docusaurus core causing instability or issues with its execution and removed documentation The issue is related to the documentation of Docusaurus status: needs triage This issue has not been triaged by maintainers labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(v2): prepend docsearch modal to body element facebook/docusaurus
3 participants
@slorber @kalinpatel @Josh-Cena