-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add stormkit as deployment platform #10011
Conversation
Hi @eldemcan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Our new policy for adding new deployment platforms in this page is to simply link to an external official resource explaining how to deploy Docusaurus to that platform, instead of explaining things in our own docs directly.
This way, we put the burden on the platform owners to ensure their Docusaurus deployment guide remains relevant.
Example: https://deploy-preview-10011--docusaurus-2.netlify.app/docs/deployment/#deploying-to-kinsta
If you are not from Stormkit, or not willing to create such official guide, I'd prefer to close this PR
website/docs/deployment.mdx
Outdated
## Deploying to Stormkit {#deploying-to-stormkit} | ||
|
||
You can deploy your Docusaurus project to Stormkit, a deployment platform for static websites, single-page applications (SPAs), and serverless functions. | ||
|
||
- Log in to [Stormkit](https://stormkit.io/). | ||
- Using the user interface, import your Docusaurus project from one of the three supported Git providers (GitHub, GitLab, or Bitbucket). | ||
- Navigate to the project’s production environment in Stormkit or create a new environment if needed. | ||
- Verify the build command in your Stormkit configuration. By default, Stormkit CI will run npm run build but you can specify a custom build command on this page. | ||
- Click the “Deploy Now” button to deploy your site. | ||
|
||
Read more in the [Stormkit Documentation](https://stormkit.io/docs/welcome/getting-started). | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is too much text, too detailed , and likely to diverge and get stale over time
@slorber thanks for your comment. I made changes that you requested. It will be easier for us to maintain as you said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 👍
Pre-flight checklist
Motivation
add stormkit as deployment platform
Test Plan
Test links
Deploy preview: https://deploy-preview-10011--docusaurus-2.netlify.app/docs/deployment/#deploying-to-stormkit
Related issues/PRs