feat(theme-mermaid): support Mermaid 11+ including new types of diagrams #10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +478 B (0%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
7 tasks
|
Can we cut a release here? |
|
we will when we are ready in the meantime you can use package manager resolution features, or use a canary release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It looks like Mermaid 11 can work out of the box under Docusaurus v3, and I suspect that might not do API breaking changes that affect us in the future.
So let's relax our npm dependency range to allow all new versions of Mermaid. We'll eventually narrow it again in case of problem.
This makes it possible to support new Mermaid 11+ types of diagrams, such as architecture diagrams (11.1+). See also #10508
Change Mermaid dependency range:
^10.4(11+ not supported)>=10.4(11+ now supported)Test Plan
preview
Test links
https://deploy-preview-10510--docusaurus-2.netlify.app/tests/pages/diagrams#architecture-diagram