Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): prefetch on mobile touchstart #8109

Merged
merged 6 commits into from
Sep 28, 2022

Conversation

sanjaiyan-dev
Copy link
Contributor

This adds handling for prefetching onTouchStart as this gives a little more time to start parsing required scripts for a page transition if not already done that can help make the transition faster.

Inspired from-: vercel/next.js#38805

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@netlify
Copy link

netlify bot commented Sep 18, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 1712894
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63277bf993531c00088e9976
😎 Deploy Preview https://deploy-preview-8109--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 82 🟢 100 🟢 100 🟢 100 🟢 90 Report

@sanjaiyan-dev
Copy link
Contributor Author

Done 🤝

@sanjaiyan-dev
Copy link
Contributor Author

@Josh-Cena Josh-Cena changed the title Add handling for prefetching onTouchStart 📱 feat(core): prefetch on mobile touchstart Sep 27, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Sep 27, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 28, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 28, 2022

thanks, makes sense to me 👍 I thought it was already optimized 😅

@slorber slorber merged commit f7c3af9 into facebook:main Sep 28, 2022
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-prefetch-onTouchStart branch September 28, 2022 13:54
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants