Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing $Shape in the utility documentation #6248

Closed
mloureiro opened this issue May 4, 2018 · 4 comments
Closed

Missing $Shape in the utility documentation #6248

mloureiro opened this issue May 4, 2018 · 4 comments

Comments

@mloureiro
Copy link

Hey guys

The only reference i found to $Shape in the documentation is this one which is inside of the last example, it is not even mentioned, but it is used.

I would expect this to be defined in the in the utilities page.

(didn't make a PR since I'm not actually sure where is the documentation repo)
@apsavin
Copy link
Contributor

apsavin commented May 4, 2018

There are some PRs already.

@mloureiro
Copy link
Author

shoot, I should have taken a look to the PRs
thanks for pointing that out @apsavin (although all of them missing the CLA signing)

@apsavin
Copy link
Contributor

apsavin commented May 4, 2018

although all of them missing the CLA signing

None of them

@mloureiro
Copy link
Author

None of them

Ah, you're right, is the other way around 👍

Closing since this is being done in:
#2464
#3967
#5251
#5706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apsavin @mloureiro