From 9c9430777ac2041a3d9faa9d87862f1e35e42d19 Mon Sep 17 00:00:00 2001 From: Andrew Krieger Date: Mon, 23 Sep 2024 20:48:16 -0700 Subject: [PATCH] Remove is_buck2() calls from folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl Summary: buck1 is declared dead, is_buck2() checks will always return true. We can statically eliminate these calls and associated conditional checks. folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl was codemodded with libcst. Reviewed By: dtolnay Differential Revision: D63295980 fbshipit-source-id: ac669ed133eadd5989343fde812fe3374fbe4628 --- folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl b/folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl index 93e4430df42..81c019a7c54 100644 --- a/folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl +++ b/folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl @@ -2,7 +2,6 @@ load("@fbcode_macros//build_defs:config.bzl", "config") load("@fbcode_macros//build_defs:cpp_library.bzl", "cpp_library") load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") load("@fbcode_macros//build_defs:custom_unittest.bzl", "custom_unittest") -load("@fbsource//tools/build_defs/buck2:is_buck2.bzl", "is_buck2") SPLIT_DWARF_FLAGS = { "none": ["-gno-split-dwarf"], @@ -32,7 +31,7 @@ def customized_unittest( for dwarf_size in available_dwarf_sizes: for split_dwarf_option in avilable_split_dwarf_keys: # buck2 doesn't support split version yet. - if split_dwarf_option == "none" or split_dwarf_option == "single_inlining" or not is_buck2(): + if split_dwarf_option == "none" or split_dwarf_option == "single_inlining": for use_aaranges in [False, True]: cpp_library( name = "symbolizer_test_utils_" + dwarf_version +