Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock date/time functions in hphp/test/frameworks/Isolation.php #3883

Closed
fredemmott opened this issue Sep 29, 2014 · 1 comment
Closed

Mock date/time functions in hphp/test/frameworks/Isolation.php #3883

fredemmott opened this issue Sep 29, 2014 · 1 comment

Comments

@fredemmott
Copy link
Contributor

To find flakey tests, they should never return the same value - eg the first call should to any of these should store time(), the second should call ($previous_value + 1), etc.

This in itself should be fairly easy; the time consuming part is that at least these frameworks must pass with --isolate:

    framework_testsuite('assetic')
    framework_testsuite('codeigniter')
    framework_testsuite('fastroute')
    framework_testsuite('idiorm')
    framework_testsuite('joomla')
    framework_testsuite('jshrink')
    framework_testsuite('klein')
    framework_testsuite('laravel')
    framework_testsuite('lessphp')
    framework_testsuite('mediawiki')
    framework_testsuite('mockery')
    framework_testsuite('monolog')
    framework_testsuite('mustache')
    framework_testsuite('paris')
    framework_testsuite('phpbb3')
    framework_testsuite('phpunit')
    framework_testsuite('ratchet')
    framework_testsuite('slim')
    framework_testsuite('twig')
@fredemmott fredemmott changed the title Stub out date/time functions in hphp/test/frameworks/Isolation.php Mock date/time functions in hphp/test/frameworks/Isolation.php Sep 29, 2014
@paulbiss
Copy link
Contributor

Closing for now as there hasn't been active work on the framework test suite for sometime now (and this is mostly a nice to have).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants