Reset context between test functions #3506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
this
context we're passing inbefore/after
(although herethis
is undefined, and I didn't even try to investigate why) andit/test
functions is preserved across consequenttest
runs, which makes it confusing to use (see #3505).As a workaround I propose passing empty object as a context for each function. This way we can still use
this
intest
but it will be unique for each test function.Fixes #3505.
Test plan
I'll add an integration test later, after we agree this is the right solution.