Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jest-haste-map): remove support for ignorePattern as function #10348

Merged
merged 8 commits into from
Dec 5, 2020
Merged

chore(jest-haste-map): remove support for ignorePattern as function #10348

merged 8 commits into from
Dec 5, 2020

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Jul 31, 2020 •
edited by SimenB
Loading

Summary

Fixes #10342

Test plan

Unit test was succeed.

unit_test_jest

@facebook-github-bot
Copy link
Contributor

Hi @komtaki!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

2 similar comments
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/jest-haste-map/src/index.ts Outdated Show resolved Hide resolved
@SimenB SimenB added this to the Jest 27 milestone Aug 1, 2020
SimenB
SimenB reviewed Aug 1, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Aug 1, 2020

I've added this to the jest 27 milestone, so I'll merge when we're ready to land breaking changes. I'll deal with conflicts at that time, so you don't have keep resolving conflicts 🙂

@SimenB
Copy link
Member

SimenB commented Sep 27, 2020

@komtaki seems we're skipping some tests on windows that are failing on mac and linux - mind taking a look?

@SimenB SimenB mentioned this pull request Sep 27, 2020
Closed
@komtaki
Copy link
Contributor Author

komtaki commented Sep 28, 2020 •
edited
Loading

@komtaki seems we're skipping some tests on windows that are failing on mac and linux - mind taking a look?

@SimenB

Sorry. I fixed on test script. So I request re review you.
I feel that the test-node-14 job fails because of another code. It happened when I turned off the test script. 🤔

@komtaki komtaki requested a review from SimenB September 28, 2020 10:26
@SimenB
Copy link
Member

SimenB commented Sep 28, 2020

We have a conflict here - can you either merge in master or rebase on it?

@komtaki
Copy link
Contributor Author

komtaki commented Oct 1, 2020

@SimenB
OK.I rebased from master branch.

And I organized commits. All CI tests passed !! 👍

@SimenB
Copy link
Member

SimenB commented Oct 1, 2020

Thanks @komtaki! This should be good to go when we're ready to land breaking changes now 👍

@SimenB SimenB merged commit bc05989 into jestjs:master Dec 5, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
Jest 27
Development

Successfully merging this pull request may close these issues.

Remove support for ignorePattern as function in jest-haste-map
3 participants
@komtaki @facebook-github-bot @SimenB