fix(circus): make sure to install globals before emitting setup event
#10598
Conversation
| await dispatch({ | ||
| name: 'setup', | ||
| parentProcess, | ||
| runtimeGlobals, |
There was a problem hiding this comment.
shall we document this somehow?
There was a problem hiding this comment.
we probably should, but the events as of now are not documented so I'd rather do that separately at some point
SimenB
changed the title
init eventsetup event
|
Looks good, I'll give it a try on the Detox suite. |
|
Btw, the idea of emitting |
| @@ -9,12 +9,11 @@ import micromatch = require('micromatch'); | |||
| import type {Config} from '@jest/types'; | |||
| import replacePathSepForGlob from './replacePathSepForGlob'; | |||
|
|
|||
| type Matcher = (str: Config.Path) => boolean; | |||
There was a problem hiding this comment.
totally unrelated, just snuck these in 🤘
|
@noomorph would love for you to confirm
I'm done changing the code in this PR now, so if you can confirm those I'll merge and make a patch release ASAP 🙂 |
|
@SimenB, yes, I've been able to confirm both your statements:
Thanks much again! Looking forward to the release! |
|
Perfect, thank you! |
|
@SimenB, excellent. We'll provide a user-friendly warning for Detox users if anyone ever encounters 26.5.0-26.5.1 versions. |
|
See: wix/Detox#2391 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix for #10484 (comment)
In addition to restoring time when globals are added, I've also added a property to the
setupevent that comes with the globals. That way consumers don't have to care aboutthis.globals.*, which would also be unset if the end user useinjectGlobals: false./cc @noomorph
Test plan
Verified locally that globals are set during
setup